From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5E6BC433DB for ; Wed, 3 Feb 2021 15:30:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8F04E64E30 for ; Wed, 3 Feb 2021 15:30:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234121AbhBCPaB (ORCPT ); Wed, 3 Feb 2021 10:30:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233243AbhBCP3l (ORCPT ); Wed, 3 Feb 2021 10:29:41 -0500 Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD0C7C061788 for ; Wed, 3 Feb 2021 07:29:01 -0800 (PST) Received: by mail-io1-xd2b.google.com with SMTP id f8so5144534ion.4 for ; Wed, 03 Feb 2021 07:29:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NnJicAfg3Ex9JmXfJakNzYykElqGIVAtmZeJOEX7nY8=; b=WeiQpgikcJrLCIIRrvoKT+fJ4jY6Z0RQYttsgwlaiWDhb9Nyi0QULctbbmad4xFQms iVWrDuSwV0HSSWcKHn9bfTEFAxLshr+xynfgxfupmdxLL5G5O6jK+cEufE94WUgzx9rg xyIiEXeJKPE8dgR15z4EeaCUwr/Ipo7tI3w3m2YKY63tMYEyNnOhQcqjAUIFnszB3aiB MT4bat6Z0dtRAwKlpIxY2EU6dOIFwrg3EWcLDcToJQ3AOo6zAQYp1pHyvF5xM5NLnyYi KOo4z5hk89tRTMoLFYcgH1CpQkSE+ryN+aQjlbgYruWhZLhl2E24IK26tLwLYxg1swyR Z1Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NnJicAfg3Ex9JmXfJakNzYykElqGIVAtmZeJOEX7nY8=; b=BJNZASID/eFMc7f8iRW54YqSN5VuoVL1kYyDa5N+tbcJSQyyGc4mK1o2dLN/SdEtNT bQiAWLUedyFTSKBCtQfjnxyVPGAq3KjTH1xYaS0w9lHGigixHlmDHII6TI9J211mReOZ GXOTby0nsKAWo2ml9vyM+s87z426ioKP1assIdFZAXN6BSKETNoVeahVOpG+bmNa9/+k 5vK2YyPL/pAdAbig/Gjq4Iai9uWQVICXO8J49VUUt8JXhtjDOJ8v7E/wCL/dMmRb1Gpq o2OOwFztm/My52KdKpU+NGf2pBrRK6JRjZ7GaVEgJMq6DnLpp/0drFgYPaQSSw+cDm4H tjBQ== X-Gm-Message-State: AOAM5327xC7fbjy0BJuwC4J5P44QdwjQA9tcmPfk4lY/W/52I0GK9aEp 9GnA5sbiU3yTd2xjv0pdgc/4Jg== X-Google-Smtp-Source: ABdhPJxm53FTgLO21S9yKfhXG6tDBqLjkGfZmwQBRkGY0S8r9C6kgi+H2HUsNlpjCU6gj7ULasIA5w== X-Received: by 2002:a05:6602:1243:: with SMTP id o3mr1622255iou.47.1612366141181; Wed, 03 Feb 2021 07:29:01 -0800 (PST) Received: from beast.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id a15sm1119774ilb.11.2021.02.03.07.29.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Feb 2021 07:29:00 -0800 (PST) From: Alex Elder To: davem@davemloft.net, kuba@kernel.org Cc: elder@kernel.org, evgreen@chromium.org, bjorn.andersson@linaro.org, cpratapa@codeaurora.org, subashab@codeaurora.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 1/7] net: ipa: restructure a few functions Date: Wed, 3 Feb 2021 09:28:49 -0600 Message-Id: <20210203152855.11866-2-elder@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210203152855.11866-1-elder@linaro.org> References: <20210203152855.11866-1-elder@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Make __gsi_channel_start() and __gsi_channel_stop() more structurally and semantically similar to each other: - Restructure __gsi_channel_start() to always return at the end of the function, similar to the way __gsi_channel_stop() does. - Move the mutex calls out of gsi_channel_stop_retry() and into __gsi_channel_stop(). Restructure gsi_channel_stop() to always return at the end of the function, like gsi_channel_start() does. Signed-off-by: Alex Elder --- drivers/net/ipa/gsi.c | 45 +++++++++++++++++++++++-------------------- 1 file changed, 24 insertions(+), 21 deletions(-) diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c index 53640447bf123..2671b76ebcfe3 100644 --- a/drivers/net/ipa/gsi.c +++ b/drivers/net/ipa/gsi.c @@ -873,17 +873,17 @@ static void gsi_channel_deprogram(struct gsi_channel *channel) static int __gsi_channel_start(struct gsi_channel *channel, bool start) { - struct gsi *gsi = channel->gsi; - int ret; + int ret = 0; - if (!start) - return 0; + if (start) { + struct gsi *gsi = channel->gsi; - mutex_lock(&gsi->mutex); + mutex_lock(&gsi->mutex); - ret = gsi_channel_start_command(channel); + ret = gsi_channel_start_command(channel); - mutex_unlock(&gsi->mutex); + mutex_unlock(&gsi->mutex); + } return ret; } @@ -910,11 +910,8 @@ int gsi_channel_start(struct gsi *gsi, u32 channel_id) static int gsi_channel_stop_retry(struct gsi_channel *channel) { u32 retries = GSI_CHANNEL_STOP_RETRIES; - struct gsi *gsi = channel->gsi; int ret; - mutex_lock(&gsi->mutex); - do { ret = gsi_channel_stop_command(channel); if (ret != -EAGAIN) @@ -922,19 +919,26 @@ static int gsi_channel_stop_retry(struct gsi_channel *channel) usleep_range(3 * USEC_PER_MSEC, 5 * USEC_PER_MSEC); } while (retries--); - mutex_unlock(&gsi->mutex); - return ret; } static int __gsi_channel_stop(struct gsi_channel *channel, bool stop) { - int ret; + int ret = 0; /* Wait for any underway transactions to complete before stopping. */ gsi_channel_trans_quiesce(channel); - ret = stop ? gsi_channel_stop_retry(channel) : 0; + if (stop) { + struct gsi *gsi = channel->gsi; + + mutex_lock(&gsi->mutex); + + ret = gsi_channel_stop_retry(channel); + + mutex_unlock(&gsi->mutex); + } + /* Finally, ensure NAPI polling has finished. */ if (!ret) napi_synchronize(&channel->napi); @@ -948,15 +952,14 @@ int gsi_channel_stop(struct gsi *gsi, u32 channel_id) struct gsi_channel *channel = &gsi->channel[channel_id]; int ret; - /* Only disable the completion interrupt if stop is successful */ ret = __gsi_channel_stop(channel, true); - if (ret) - return ret; + if (ret) { + /* Disable the completion interrupt and NAPI if successful */ + gsi_irq_ieob_disable_one(gsi, channel->evt_ring_id); + napi_disable(&channel->napi); + } - gsi_irq_ieob_disable_one(gsi, channel->evt_ring_id); - napi_disable(&channel->napi); - - return 0; + return ret; } /* Reset and reconfigure a channel, (possibly) enabling the doorbell engine */ -- 2.20.1