Re: [PATCH 09/13] pci: dwc: pcie-kirin: allow to optionally require a regulator

Mauro Carvalho Chehab
2021-02-02T14:56:10Z

Hi Mark,

Em Tue, 2 Feb 2021 13:41:01 +0000
Mark Brown <broonie@kernel.org> escreveu:

> On Tue, Feb 02, 2021 at 02:29:54PM +0100, Mauro Carvalho Chehab wrote:
> > On Hikey 970, there's a power supply controlled by Hi6421v600
> > regulator that turns on the PCI devices on the board. Without
> > that, no PCI hardware would work.
> >
> > As this is device-dependent, such regulator line should be
> > optional.
>
> Supplies should only be optional if they may be physically absent from
> the system,

That's the case. On Hikey 960, the PCIe hardware supported by this
driver doesn't require any regulator.

On Hikey 970, the PCIe hardware is more complex. Some components
are outside the SoC, and those require a regulator to be powered
up.

> if they are just sometimes not described well in firmware
> they should be requested via the normal regulator_get() interface, the
> core will supply a dummy regulator if there is nothing at all in the
> firmware description.

For Hikey 970, a normal regulator_get() would work.

> Supplies should also generally be referred to with the naming used in
> the datasheet for the part.

Ok, I'll rename it to "pcie_vdd", which better reflects the
schematics.

Thanks,
Mauro