Re: [PATCH v2 3/4] mm: Introduce page_needs_cow_for_dma() for deciding whether cow

Peter Xu
2021-02-05T00:52:09Z

On Thu, Feb 04, 2021 at 07:20:00PM -0400, Jason Gunthorpe wrote:
> > +static inline bool is_cow_mapping(vm_flags_t flags)
> > +{
>
> It feels a bit more logical to pass in a struct vm_area_struct *' here?

Agree, but only if I'm adding this as a new function. Though it's a code
movement from internal.h to mm.h, so I avoided touching all the users of this
function that existed.

Thanks,

--
Peter Xu