Re: [PATCH v2 4/4] hugetlb: Do early cow when page pinned on src mm

Peter Xu
2021-02-07T15:33:07Z

On Sun, Feb 07, 2021 at 11:09:29AM +0200, Gal Pressman wrote:
> On 05/02/2021 17:51, Peter Xu wrote:
> > On Fri, Feb 05, 2021 at 02:58:33PM +0000, Zhang, Wei wrote:
> >> Hi Peter,
> >
> > Hi, Wei,
> >
> >>
> >> Gal and I worked together. We tested the patch v2 and can confirm it is working as intended.
> >>
> >> Thank you very much for your quick response!
> >
> > My thanks too on the quick testing! Sorry that I'll need to post v3; please
> > feel free to hold off the testing until I got some r-bs with the new version.
>
> BTW, it might already be fixed in v3, but I encountered a compilation warning
> with this series:
>
> mm/memory.c: In function ‘copy_present_page’:
> mm/memory.c:800:20: warning: unused variable ‘src_mm’ [-Wunused-variable]
> struct mm_struct *src_mm = src_vma->vm_mm;
> ^~~~~~

Not yet, thanks for raising this, Gal. I'll wait for some more review feedback
on v3 and send a new version with it fixed.

--
Peter Xu