From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12928C433DB for ; Fri, 5 Feb 2021 10:39:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC23964F40 for ; Fri, 5 Feb 2021 10:39:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231599AbhBEKjJ (ORCPT ); Fri, 5 Feb 2021 05:39:09 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:38410 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231504AbhBEKfZ (ORCPT ); Fri, 5 Feb 2021 05:35:25 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id A93511C0B77; Fri, 5 Feb 2021 11:34:39 +0100 (CET) Date: Fri, 5 Feb 2021 11:34:38 +0100 From: Pavel Machek To: Sven Schuchmann Cc: Dan Murphy , "linux-leds@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 2/4] leds: lp50xx: add setting of default intensity from DT Message-ID: <20210205103438.GB27854@amd> References: <20210204143738.28036-1-schuchmann@schleissheimer.de> <20210204145308.GC14305@duo.ucw.cz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="98e8jtXdkpgskNou" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --98e8jtXdkpgskNou Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri 2021-02-05 09:59:19, Sven Schuchmann wrote: > Hello Pavel, >=20 > > > diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c > > > index f13117eed976..4b40bf66483c 100644 > > > --- a/drivers/leds/leds-lp50xx.c > > > +++ b/drivers/leds/leds-lp50xx.c > > > @@ -267,7 +267,6 @@ struct lp50xx_led { > > > struct led_classdev_mc mc_cdev; > > > struct lp50xx *priv; > > > unsigned long bank_modules; > > > - int led_intensity[LP50XX_LEDS_PER_MODULE]; > > > u8 ctrl_bank_enabled; > > > int led_number; > > > }; > >=20 > > ? Does not make sense and changelog does not help. >=20 > This is an unused variable which is in the driver > (same as the regulator). Should I provide a patch on its own for that > or just describe in the changelog? Lets do separate patch here. DT changes will need Ack from Rob, this can go in directly. Can you or Dan submit patch getting the regulator support to work? If not, I guess we should remove the regulator support after all. Best regards, Pavel --=20 http://www.livejournal.com/~pavelmachek --98e8jtXdkpgskNou Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmAdHz4ACgkQMOfwapXb+vKA+ACeLp1dQc6RSRQU1sKNLCNENWBw S9kAoIs6k+22co4C5R0TPxCQ7JQxCJmM =0pUB -----END PGP SIGNATURE----- --98e8jtXdkpgskNou--