Re: [PATCH v3] mfd: da9063: Support SMBus and I2C mode

Wolfram Sang
2021-02-06T04:22:15Z

[-- Attachment #1: Type: text/plain, Size: 429 bytes --]

> + if (i2c_check_functionality(i2c->adapter, I2C_FUNC_I2C)) {
> + dev_info(da9063->dev, "I2C mode");
> + busmode = 0;
> + } else {
> + dev_info(da9063->dev, "SMBus mode");
> + busmode = DA9063_TWOWIRE_TO;
> + }

In principle, this looks good and is sane to do. I'd just suggest to
leave out the dev_info calls and maybe just do:

busmode = i2c_check_functionality(i2c->adapter, I2C_FUNC_I2C) ?
0 : DA9063_TWOWIRE_TO;

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]