Re: [PATCH 1/2] leds: lp50xx: remove unused regulator

Rob Herring
2021-02-05T18:07:37Z

On Wed, Feb 03, 2021 at 08:33:05AM +0000, Sven Schuchmann wrote:
> The regulator for vled-supply is unused in the driver.
> It is just assigned from DT and disabled in lp50xx_remove.
> So the code can be removed from the driver.

The binding is not a driver. Does the h/w have a 'vled' supply? If so,
then it should remain in the binding.

>
> Part 1 updates the documentation
> Part 2 removes the code
>
> Signed-off-by: Sven Schuchmann <schuchmann@schleissheimer.de>
>
> ---
> Documentation/devicetree/bindings/leds/leds-lp50xx.yaml | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
> index c192b5feadc7..c20a81d13bfd 100644
> --- a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
> @@ -43,9 +43,6 @@ properties:
> maxItems: 1
> description: GPIO pin to enable/disable the device.
>
> - vled-supply:
> - description: LED supply.
> -
> '#address-cells':
> const: 1
>
> --
> 2.17.1
>