From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DD6EC433DB for ; Sat, 6 Feb 2021 09:08:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 62E4864FA1 for ; Sat, 6 Feb 2021 09:08:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229539AbhBFJFb (ORCPT ); Sat, 6 Feb 2021 04:05:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229492AbhBFJEy (ORCPT ); Sat, 6 Feb 2021 04:04:54 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9780C06174A for ; Sat, 6 Feb 2021 01:04:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZF97VIJoz6En75OLdh7F+uFHUq2TFG5w7tIH8/c2dcA=; b=T2U3nOQS1YS2g/ZYRMACBrwf4+ atYgkfbQPCulLBHwLxRnxLaQxtCTXyFZp0ukEQuigiao2Zk7Ck+xAHhzmyYaGaO2wvLuIyGJI+f/A kfr9zuxEWmRLJV+NNTUoFU/Ofs/o0bOsDkfrDHHMldJYpCCjTuBpPKhodoIncjYd8CoqP/N+Q3Irt ZokwJ1/f9B5r+QAwW9ROsyK5RmDW6tL7H+0FxkKbm/zgAaK21BFR5PQw4H3NTH5vLTfWJnH7Ee17E psFz8mHVlsgmcQD139VnNI+jZtxYFlJJ/NLtgC6cPEfQGFuhMdJAZ0eG26ktAAIRvHldXdoIb0L8U 7RCdymrQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1l8JVE-003Nqu-5m; Sat, 06 Feb 2021 09:03:40 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 8452D981194; Sat, 6 Feb 2021 10:03:38 +0100 (CET) Date: Sat, 6 Feb 2021 10:03:38 +0100 From: Peter Zijlstra To: Josh Poimboeuf Cc: Frederic Weisbecker , LKML , Mel Gorman , Michal Hocko , Thomas Gleixner , "Paul E . McKenney" , Ingo Molnar , Michal Hocko , rostedt@goodmis.org, jbaron@akamai.com, ardb@kernel.org Subject: Re: [RFC PATCH 6/8] preempt/dynamic: Provide preempt_schedule[_notrace]() static calls Message-ID: <20210206090338.GK8912@worktop.programming.kicks-ass.net> References: <20210127155914.jfmr4jay47yck5h5@treble> <20210127163308.cgiq7jxx2uziuhcc@treble> <20210127190003.64rdwoxyjgnq2rtx@treble> <20210127190218.hoztl7eidujqarkt@treble> <20210127231837.ifddpn7rhwdaepiu@treble> <20210206023122.ijbihwpzrcxzhi52@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210206023122.ijbihwpzrcxzhi52@treble> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 05, 2021 at 08:31:22PM -0600, Josh Poimboeuf wrote: > On Fri, Feb 05, 2021 at 04:30:56PM +0100, Peter Zijlstra wrote: > > On Wed, Feb 03, 2021 at 03:04:23PM +0100, Peter Zijlstra wrote: > > > Fair enough I suppose. I'll slap a changelog and your SoB on it and I > > > suppose I'll got commit the whole lot. Then we can forget about it > > > again. > > > > FWIW, the whole thing looks like this.. > > > > --- > > Subject: static_call: Allow module use without exposing static_call_key > > From: Josh Poimboeuf > > Date: Wed, 27 Jan 2021 17:18:37 -0600 > > > > From: Josh Poimboeuf > > > > When exporting static_call_key; with EXPORT_STATIC_CALL*(), the module > > can use static_call_update() to change the function called. This is > > not desirable in general. > > Looks good to me, thanks for fixing that up. Never said I tested it ;-) Yeah, and I'm the genius that 'tested' it with a MODULES=n build :-)