From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 775F7C433E6 for ; Mon, 8 Feb 2021 11:31:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 22CA464E42 for ; Mon, 8 Feb 2021 11:31:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233306AbhBHLbj (ORCPT ); Mon, 8 Feb 2021 06:31:39 -0500 Received: from mga18.intel.com ([134.134.136.126]:59432 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232976AbhBHLPF (ORCPT ); Mon, 8 Feb 2021 06:15:05 -0500 IronPort-SDR: TMq7oxGPelG/nzQGQBDbqrWmT6kK6gjYXKtMj/bxc9pZ5TeO+36a2eehGgmhzA/g2WacZh7nfJ i2HwyrZbD9Ag== X-IronPort-AV: E=McAfee;i="6000,8403,9888"; a="169378381" X-IronPort-AV: E=Sophos;i="5.81,161,1610438400"; d="scan'208";a="169378381" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2021 03:14:33 -0800 IronPort-SDR: lA27CDMeGMuk8SvdsngoCIJZE8Cr75TO2q+9m0WaHjM/8MI85ZJjjpiUyAP+l3ZPRMbwzyHV3R Y+7WJBzyPO4Q== X-IronPort-AV: E=Sophos;i="5.81,161,1610438400"; d="scan'208";a="374455211" Received: from anveshag-mobl1.amr.corp.intel.com (HELO intel.com) ([10.209.119.193]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2021 03:14:32 -0800 Date: Mon, 8 Feb 2021 06:14:30 -0500 From: Rodrigo Vivi To: Lyude Paul Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, David Airlie , open list , Sean Paul Subject: Re: [RFC v3 07/10] drm/i915/dpcd_bl: Move VESA backlight enabling code closer together Message-ID: <20210208111430.GC4798@intel.com> References: <20210205234515.1216538-1-lyude@redhat.com> <20210205234515.1216538-8-lyude@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210205234515.1216538-8-lyude@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 05, 2021 at 06:45:11PM -0500, Lyude Paul wrote: > No functional changes, just move set_vesa_backlight_enable() closer to it's > only caller: intel_dp_aux_vesa_enable_backlight(). > > Signed-off-by: Lyude Paul Reviewed-by: Rodrigo Vivi > --- > .../drm/i915/display/intel_dp_aux_backlight.c | 54 +++++++++---------- > 1 file changed, 27 insertions(+), 27 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > index f5ae2fb34c1f..431758058aa0 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > @@ -270,33 +270,6 @@ intel_dp_aux_hdr_setup_backlight(struct intel_connector *connector, enum pipe pi > } > > /* VESA backlight callbacks */ > -static void set_vesa_backlight_enable(struct intel_connector *connector, bool enable) > -{ > - struct intel_dp *intel_dp = intel_attached_dp(connector); > - struct drm_i915_private *i915 = dp_to_i915(intel_dp); > - u8 reg_val = 0; > - > - /* Early return when display use other mechanism to enable backlight. */ > - if (!connector->panel.backlight.edp.vesa.aux_enable) > - return; > - > - if (drm_dp_dpcd_readb(&intel_dp->aux, DP_EDP_DISPLAY_CONTROL_REGISTER, ®_val) != 1) { > - drm_dbg_kms(&i915->drm, "Failed to read DPCD register 0x%x\n", > - DP_EDP_DISPLAY_CONTROL_REGISTER); > - return; > - } > - if (enable) > - reg_val |= DP_EDP_BACKLIGHT_ENABLE; > - else > - reg_val &= ~(DP_EDP_BACKLIGHT_ENABLE); > - > - if (drm_dp_dpcd_writeb(&intel_dp->aux, DP_EDP_DISPLAY_CONTROL_REGISTER, > - reg_val) != 1) { > - drm_dbg_kms(&i915->drm, "Failed to %s aux backlight\n", > - enable ? "enable" : "disable"); > - } > -} > - > static bool intel_dp_aux_vesa_backlight_dpcd_mode(struct intel_connector *connector) > { > struct intel_dp *intel_dp = intel_attached_dp(connector); > @@ -378,6 +351,33 @@ intel_dp_aux_vesa_set_backlight(const struct drm_connector_state *conn_state, > } > } > > +static void set_vesa_backlight_enable(struct intel_connector *connector, bool enable) > +{ > + struct intel_dp *intel_dp = intel_attached_dp(connector); > + struct drm_i915_private *i915 = dp_to_i915(intel_dp); > + u8 reg_val = 0; > + > + /* Early return when display use other mechanism to enable backlight. */ > + if (!connector->panel.backlight.edp.vesa.aux_enable) > + return; > + > + if (drm_dp_dpcd_readb(&intel_dp->aux, DP_EDP_DISPLAY_CONTROL_REGISTER, ®_val) != 1) { > + drm_dbg_kms(&i915->drm, "Failed to read DPCD register 0x%x\n", > + DP_EDP_DISPLAY_CONTROL_REGISTER); > + return; > + } > + if (enable) > + reg_val |= DP_EDP_BACKLIGHT_ENABLE; > + else > + reg_val &= ~(DP_EDP_BACKLIGHT_ENABLE); > + > + if (drm_dp_dpcd_writeb(&intel_dp->aux, DP_EDP_DISPLAY_CONTROL_REGISTER, > + reg_val) != 1) { > + drm_dbg_kms(&i915->drm, "Failed to %s aux backlight\n", > + enable ? "enable" : "disable"); > + } > +} > + > static void > intel_dp_aux_vesa_enable_backlight(const struct intel_crtc_state *crtc_state, > const struct drm_connector_state *conn_state, u32 level) > -- > 2.29.2 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel