From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9498C433E0 for ; Wed, 10 Feb 2021 07:39:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F80F64E3B for ; Wed, 10 Feb 2021 07:39:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232792AbhBJHip (ORCPT ); Wed, 10 Feb 2021 02:38:45 -0500 Received: from verein.lst.de ([213.95.11.211]:49660 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232484AbhBJHim (ORCPT ); Wed, 10 Feb 2021 02:38:42 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id EACAD67373; Wed, 10 Feb 2021 08:37:59 +0100 (CET) Date: Wed, 10 Feb 2021 08:37:59 +0100 From: Christoph Hellwig To: Filippo Sironi Cc: serebrin@amazon.com, dwmw@amazon.co.uk, benh@amazon.com, kbusch@kernel.org, axboe@fb.com, hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] nvme: Add 48-bit DMA address quirk for Amazon NVMe controllers Message-ID: <20210210073759.GA23269@lst.de> References: <20210203094338.19473-1-sironi@amazon.de> <20210210003942.25700-1-sironi@amazon.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210210003942.25700-1-sironi@amazon.de> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 10, 2021 at 01:39:42AM +0100, Filippo Sironi wrote: > Amazon NVMe controllers do not support 64-bit DMA addresses; they are > limited to 48-bit DMA addresses. Let's add a quirk to ensure that we > make use of 48-bit DMA addresses to avoid misbehavior. This should probably say some, and mention that they do not follow the spec. But I can fix this up when applying the patch.