From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4F31C433DB for ; Wed, 10 Feb 2021 14:28:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B76A64DC3 for ; Wed, 10 Feb 2021 14:28:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231148AbhBJO2o (ORCPT ); Wed, 10 Feb 2021 09:28:44 -0500 Received: from mx2.suse.de ([195.135.220.15]:40206 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229789AbhBJO23 (ORCPT ); Wed, 10 Feb 2021 09:28:29 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 20294B0D1; Wed, 10 Feb 2021 14:27:48 +0000 (UTC) Date: Wed, 10 Feb 2021 15:27:45 +0100 From: Oscar Salvador To: Vlastimil Babka Cc: David Hildenbrand , Minchan Kim , Andrew Morton , linux-mm , LKML , Michal Hocko Subject: Re: [PATCH] mm: remove lru_add_drain_all in alloc_contig_range Message-ID: <20210210142745.GD3636@localhost.localdomain> References: <20210209175048.361638-1-minchan@kernel.org> <20210209190332.GA3363@localhost.localdomain> <49491777-6d61-db4d-5e90-7a8b9045faca@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49491777-6d61-db4d-5e90-7a8b9045faca@suse.cz> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 10, 2021 at 01:17:33PM +0100, Vlastimil Babka wrote: > AFAICS, at the time page migration used putback_lru_page() to release the > migration source page. This would put the page on lru pvec even if it was in > fact not mapped anywhere anymore, and only the drain would actually free it. > Seems Minchan optimized this in 2016 by c6c919eb90e0 ("mm: use put_page() to > free page instead of putback_lru_page()") Ok, I see. Thanks for this valuable information Vlastimil. -- Oscar Salvador SUSE L3