Re: [PATCH] clk: at91: Fix the declaration of the clocks

Eugen.Hristev
2021-02-04T12:48:07Z

On 03.02.2021 20:15, Saravana Kannan wrote:
> On Wed, Feb 3, 2021 at 7:43 AM Tudor Ambarus
> <tudor.ambarus@microchip.com> wrote:
>>
>> These are all "early clocks" that require initialization just at
>> of_clk_init() time. Use CLK_OF_DECLARE() to declare them.
>>
>> This also fixes a problem that was spotted when fw_devlink was
>> set to 'on' by default: the boards failed to boot. The reason is
>> that CLK_OF_DECLARE_DRIVER() clears the OF_POPULATED and causes
>> the consumers of the clock to be postponed by fw_devlink until
>> the second initialization routine of the clock has been completed.
>> One of the consumers of the clock is the timer, which is used as a
>> clocksource, and needs the clock initialized early. Postponing the
>> timers caused the fail at boot.
>>
>> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
>
> Thanks Tudor!
> Acked-by: Saravana Kannan <saravanak@google.com>
>
> -Saravana
>
>> ---
>> Tested on sama5d2_xplained.
>>

For sama5d3_xplained, sama5d4_xplained,
Tested-by: Eugen Hristev <eugen.hristev@microchip.com>