From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DACAFC433DB for ; Wed, 10 Feb 2021 20:01:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B9E264EDC for ; Wed, 10 Feb 2021 20:01:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232956AbhBJUBk (ORCPT ); Wed, 10 Feb 2021 15:01:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232742AbhBJUBe (ORCPT ); Wed, 10 Feb 2021 15:01:34 -0500 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3213C06174A for ; Wed, 10 Feb 2021 12:00:53 -0800 (PST) Received: by mail-yb1-xb4a.google.com with SMTP id v196so3712741ybv.3 for ; Wed, 10 Feb 2021 12:00:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:message-id:mime-version:subject:from:to:cc; bh=nAWyJ+zxkv0LYbUQRaRKMv3uecWVrQKPIIyiCbLAoxY=; b=aYx2s5uTYXvURxGfXo2FePoZlMBgiLhXFh8iGW6wYkkIIEVjBdHHE5Bmr+zKX5LqVE sXAE9oLKNYAF6Eo3GNppSO3S8wL5KoL43p4Utf1urdr1Cx8BiVzYlT3vitvVq1VO2dZZ vFY51evq5GqIQdt3BGAiNWVi5v8zJzrJB9B8M6oUfSmcW2y7h2YHsrwLpC0D6cGeiCh7 sirmlE9KYu4PaWV/84XvvlDexO0dBEQQmKomiGUeKKwIMcJsoJi75xodus7bGArPlXPp iwsPzZ2jQNs3SOeStu+4Q9xrITQ+FBJ0ZwwRKreYP/JKJZJNENb5olCjsrV/ebSFuG8O bmlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:message-id:mime-version:subject:from :to:cc; bh=nAWyJ+zxkv0LYbUQRaRKMv3uecWVrQKPIIyiCbLAoxY=; b=sX/QovrIhoF6BGv1Z6c1cmW4WbL3BF2oJIbFS36MT09zmhD4bjjVUYleePtgi6lR6r YuoXARvZPy8GxURWOujxp8Nr3K972qp6qi3v3zwH8HOj3uE4gH4bCJ3DBaNusOi3Rcnu KDzPYBjxLvaUIoDd1yOCbcahQrPQGo6+19UFkJRPAVpQaKpi8hKwnJGsxBsBjmqiXB7/ JkgiyUu03SVED7MjelWqAZs6M86EXd5eXNcKplja63wnNpFBdzKWUoSnUrNZ83vcW5z7 eMDvySEu81d9/EFSvbEpPs9dyu8zwfbMgzxbg41TULVtNQoUCFnjYMleXr7YM9VRFqDe kXAg== X-Gm-Message-State: AOAM5314wB5byoEYyoSQcSV9mQB9tP/alCYmfy+nvHy+VAgnsw6gR0zM BQa8isV1Nn9SXP3tTt4+G4yPM+Qm6bdcht8= X-Google-Smtp-Source: ABdhPJwmVag+wQKQjAADmpTdq761ecbwOkwNmoZOkg6ITLu+atzaYLx1Kpp0+J/C5kPa7r7f66aTWjvXw0sVbVE= Sender: "saravanak via sendgmr" X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:6d2c:28df:85a5:da6c]) (user=saravanak job=sendgmr) by 2002:a25:9b88:: with SMTP id v8mr6980038ybo.338.1612987253194; Wed, 10 Feb 2021 12:00:53 -0800 (PST) Date: Wed, 10 Feb 2021 12:00:49 -0800 Message-Id: <20210210200050.4106032-1-saravanak@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.30.0.478.g8a0d178c01-goog Subject: [PATCH] of: irq: Fix the return value for of_irq_parse_one() stub From: Saravana Kannan To: Rob Herring , Frank Rowand , Greg Kroah-Hartman , Stephen Rothwell Cc: Saravana Kannan , kernel-team@android.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When commit 1852ebd13542 ("of: irq: make a stub for of_irq_parse_one()") added a stub for of_irq_parse_one() it set the return value to 0. Return value of 0 in this instance means the call succeeded and the out_irq pointer was filled with valid data. So, fix it to return an error value. Fixes: 1852ebd13542 ("of: irq: make a stub for of_irq_parse_one()") Signed-off-by: Saravana Kannan --- This needs to go into driver-core. -Saravana include/linux/of_irq.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/of_irq.h b/include/linux/of_irq.h index f898d838d201..aaf219bd0354 100644 --- a/include/linux/of_irq.h +++ b/include/linux/of_irq.h @@ -60,7 +60,7 @@ u32 of_msi_map_id(struct device *dev, struct device_node *msi_np, u32 id_in); static inline int of_irq_parse_one(struct device_node *device, int index, struct of_phandle_args *out_irq) { - return 0; + return -EINVAL; } static inline int of_irq_count(struct device_node *dev) { -- 2.30.0.478.g8a0d178c01-goog