Re: [PATCH v2 1/2] pinctrl: use to octal permissions for debugfs files

Andy Shevchenko
2021-02-10T10:28:23Z

On Wed, Feb 10, 2021 at 10:31 AM Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Wed, Feb 10, 2021 at 8:50 AM Drew Fustini <drew@beagleboard.org> wrote:

...

> > - debugfs_create_file("pinctrl-devices", S_IFREG | S_IRUGO,
> > + debugfs_create_file("pinctrl-devices", 0400,
>
> What about the loss of S_IFREG?

What do you mean?
https://elixir.bootlin.com/linux/latest/source/fs/debugfs/inode.c#L387

--
With Best Regards,
Andy Shevchenko