Re: [PATCH net-next v2 2/5] lan743x: sync only the received area of an rx ring buffer

Sven Van Asbroeck
2021-02-12T22:48:38Z

Hi Bryan,

On Fri, Feb 12, 2021 at 3:45 PM <Bryan.Whitehead@microchip.com> wrote:
>
> According to the document I have, FRAME_LENGTH is only valid when LS bit is set, and reserved otherwise.
> Therefore, I'm not sure you can rely on it being zero when LS is not set, even if your experiments say it is.
> Future chip revisions might use those bits differently.

That's good to know. I didn't find any documentation related to
multi-buffer frames, so I had to go with what I saw the chip do
experimentally. It's great that you were able to double-check against
the official docs.

>
> Can you change this so the LS bit is checked.
> If set you can use the smaller of FRAME_LENGTH or buffer length.
> If clear you can just use buffer length.

Will do. Are you planning to hold off your tests until v3? It
shouldn't take too long.