From: Pavel Machek <pavel@ucw.cz>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: kernel test robot <lkp@intel.com>, Arnd Bergmann <arnd@arndb.de>,
kbuild-all@lists.01.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>
Subject: Re: drivers/leds/flash/leds-rt8515.c:216: undefined reference to `v4l2_flash_release'
Date: Fri, 12 Feb 2021 14:32:54 +0100 [thread overview]
Message-ID: <20210212133254.GA31749@duo.ucw.cz> (raw)
In-Reply-To: <CACRpkdbEecZZ8UUtmBY3tiK51zv-Y7S=4wjHqqzubz4odzMt+w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1328 bytes --]
On Fri 2021-02-12 13:38:58, Linus Walleij wrote:
> I need Arnds help with this...
>
> On Fri, Feb 12, 2021 at 12:05 AM kernel test robot <lkp@intel.com> wrote:
>
> > ld: drivers/leds/flash/leds-rt8515.o: in function `rt8515_v4l2_flash_release':
> > >> drivers/leds/flash/leds-rt8515.c:216: undefined reference to `v4l2_flash_release'
> > ld: drivers/leds/flash/leds-rt8515.o: in function `rt8515_probe':
> > drivers/leds/flash/leds-rt8515.c:354: undefined reference to `v4l2_flash_init'
>
> So the problem is that this is compiled in, so CONFIG_LEDS_RT8515=y
> (it is tristate so can also be a module)
> but it depends on symbols from a module:
> CONFIG_V4L2_FLASH_LED_CLASS=m.
>
> In the code I try to only support the V4L2 interface when using V4L2:
> #if IS_ENABLED(CONFIG_V4L2_FLASH_LED_CLASS)
> (... V4L2 code...)
>
> Is there a way to define in Kconfig that if and only if you enable
> this other module it has to follow the y or m that we use for this
> driver?
>
> Or do I simply have to bite the bullet, make it bool and
> depend on CONFIG_V4L2_FLASH_LED_CLASS || !CONFIG_V4L2_FLASH_LED_CLASS
> ?
Arnd already submitted patch for this one... depends is right, no need
to make it bool, I believe.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
prev parent reply other threads:[~2021-02-12 13:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 23:04 drivers/leds/flash/leds-rt8515.c:216: undefined reference to `v4l2_flash_release' kernel test robot
2021-02-12 12:38 ` Linus Walleij
2021-02-12 13:32 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210212133254.GA31749@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=arnd@arndb.de \
--cc=kbuild-all@lists.01.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox