Re: [PATCH v2 5/5] ACPI: property: Refactor acpi_data_prop_read_single()

Andy Shevchenko
2021-02-12T16:03:09Z

On Fri, Feb 12, 2021 at 03:31:24PM +0100, Rafael J. Wysocki wrote:
> On Fri, Feb 12, 2021 at 3:14 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:

> > Refactor acpi_data_prop_read_single() for less LOCs and better maintenance.

Thanks for review, my answers below.

...

> > + if (ret)
> > + return ret;
>
> else if (!val)
> ret = 1;

But then it become a bug again :-)

...

> And this is just not looking good to me, sorry.

Yeah, I think this patch is not needed right now. At least it seems no gain
from it.

--
With Best Regards,
Andy Shevchenko