* [PATCH] staging: greybus: minor code style fix
@ 2021-02-12 22:50 Manikantan Ravichandran
2021-02-16 15:31 ` Alex Elder
0 siblings, 1 reply; 2+ messages in thread
From: Manikantan Ravichandran @ 2021-02-12 22:50 UTC (permalink / raw)
To: vaibhav.sr, mgreer, johan, elder, gregkh; +Cc: greybus-dev, devel, linux-kernel
checkpatch warning fix for string split across lines
Signed-off-by: Manikantan Ravichandran <ravman1991@gmail.com>
---
drivers/staging/greybus/audio_manager_sysfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/audio_manager_sysfs.c b/drivers/staging/greybus/audio_manager_sysfs.c
index ab882cc49b41..fcd518f9540c 100644
--- a/drivers/staging/greybus/audio_manager_sysfs.c
+++ b/drivers/staging/greybus/audio_manager_sysfs.c
@@ -18,8 +18,8 @@ static ssize_t manager_sysfs_add_store(struct kobject *kobj,
struct gb_audio_manager_module_descriptor desc = { {0} };
int num = sscanf(buf,
- "name=%" GB_AUDIO_MANAGER_MODULE_NAME_LEN_SSCANF "s "
- "vid=%d pid=%d intf_id=%d i/p devices=0x%X o/p devices=0x%X",
+ "name=%" GB_AUDIO_MANAGER_MODULE_NAME_LEN_SSCANF
+ "s vid=%d pid=%d intf_id=%d i/p devices=0x%X o/p devices=0x%X",
desc.name, &desc.vid, &desc.pid, &desc.intf_id,
&desc.ip_devices, &desc.op_devices);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: greybus: minor code style fix
2021-02-12 22:50 [PATCH] staging: greybus: minor code style fix Manikantan Ravichandran
@ 2021-02-16 15:31 ` Alex Elder
0 siblings, 0 replies; 2+ messages in thread
From: Alex Elder @ 2021-02-16 15:31 UTC (permalink / raw)
To: Manikantan Ravichandran, vaibhav.sr, mgreer, johan, elder, gregkh
Cc: greybus-dev, devel, linux-kernel
On 2/12/21 4:50 PM, Manikantan Ravichandran wrote:
> checkpatch warning fix for string split across lines
>
> Signed-off-by: Manikantan Ravichandran <ravman1991@gmail.com>
I think what you're doing here *looks* reasonable. But
the GB_AUDIO_MANAGER_MODULE_NAME_LEN_SSCANF symbol is
a (string) numeric value that is associated with the
"s" that immediately follows it.
So I don't think your change makes sense, given the
meaning of the line you're changing.
Thanks.
-Alex
> ---
> drivers/staging/greybus/audio_manager_sysfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/audio_manager_sysfs.c b/drivers/staging/greybus/audio_manager_sysfs.c
> index ab882cc49b41..fcd518f9540c 100644
> --- a/drivers/staging/greybus/audio_manager_sysfs.c
> +++ b/drivers/staging/greybus/audio_manager_sysfs.c
> @@ -18,8 +18,8 @@ static ssize_t manager_sysfs_add_store(struct kobject *kobj,
> struct gb_audio_manager_module_descriptor desc = { {0} };
>
> int num = sscanf(buf,
> - "name=%" GB_AUDIO_MANAGER_MODULE_NAME_LEN_SSCANF "s "
> - "vid=%d pid=%d intf_id=%d i/p devices=0x%X o/p devices=0x%X",
> + "name=%" GB_AUDIO_MANAGER_MODULE_NAME_LEN_SSCANF
> + "s vid=%d pid=%d intf_id=%d i/p devices=0x%X o/p devices=0x%X",
> desc.name, &desc.vid, &desc.pid, &desc.intf_id,
> &desc.ip_devices, &desc.op_devices);
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-16 15:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-12 22:50 [PATCH] staging: greybus: minor code style fix Manikantan Ravichandran
2021-02-16 15:31 ` Alex Elder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox