From: Dan Carpenter <dan.carpenter@oracle.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, elder@kernel.org,
linux-kernel@vger.kernel.org, johan@kernel.org,
greybus-dev@lists.linaro.org,
Hemansh Agnihotri <hemanshagnihotri27@gmail.com>
Subject: Re: [greybus-dev] [PATCH 1/1] staging: greybus: Added do - while in multi statement macro
Date: Mon, 15 Feb 2021 13:52:02 +0300 [thread overview]
Message-ID: <20210215105202.GA2087@kadam> (raw)
In-Reply-To: <20210211101039.m5q26qgxififotqp@vireshk-i7>
On Thu, Feb 11, 2021 at 03:40:39PM +0530, Viresh Kumar wrote:
> On 11-02-21, 11:00, Greg KH wrote:
> > On Thu, Feb 11, 2021 at 03:24:44PM +0530, Hemansh Agnihotri wrote:
> > > This patch add fixes an checkpatch error for "Macros with multiple statements
> > > should be enclosed in a do - while loop"
> > >
> > > Signed-off-by: Hemansh Agnihotri <hemanshagnihotri27@gmail.com>
> >
> > Any reason you didn't test-build your patch before sending it out?
> >
> > That's a bit rude to reviewers :(
>
> I also wonder how two people stumbled upon the exact same thing at the
> same time. Copy/paste ?
>
Those things are pretty common where people try to fix the first
checkpatch warning they find. There was one time some years back when 5
people sent the same patch.
regards,
dan carpenter
next prev parent reply other threads:[~2021-02-15 10:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 9:54 [PATCH 1/1] staging: greybus: Added do - while in multi statement macro Hemansh Agnihotri
2021-02-11 10:00 ` Greg KH
2021-02-11 10:10 ` [greybus-dev] " Viresh Kumar
2021-02-15 10:52 ` Dan Carpenter [this message]
2021-02-11 13:07 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210215105202.GA2087@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=hemanshagnihotri27@gmail.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox