From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2A1AC433DB for ; Tue, 16 Feb 2021 11:36:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 902B364DDA for ; Tue, 16 Feb 2021 11:36:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230000AbhBPLgG (ORCPT ); Tue, 16 Feb 2021 06:36:06 -0500 Received: from mga04.intel.com ([192.55.52.120]:47562 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230144AbhBPLeo (ORCPT ); Tue, 16 Feb 2021 06:34:44 -0500 IronPort-SDR: OqFcnP89RylOvexYY4qCFdOWUYl46IMiYEgHpO9LGKXTWmBVowY+WlQy8PKC3GqNXAPBpmVEaM vNGXvRP0OxCA== X-IronPort-AV: E=McAfee;i="6000,8403,9896"; a="180301354" X-IronPort-AV: E=Sophos;i="5.81,183,1610438400"; d="scan'208";a="180301354" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Feb 2021 03:32:52 -0800 IronPort-SDR: Q5q6IwXgrtnwEgUKr595xikf9QikU3neu6k34PkymGtLv5dsLsQnYxRaLAmnkVOFQlIvUfRWqE d9dAQ7J2J/sA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,183,1610438400"; d="scan'208";a="366422974" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga007.fm.intel.com with ESMTP; 16 Feb 2021 03:32:51 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 65D58169; Tue, 16 Feb 2021 13:32:50 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-kernel@vger.kernel.org Cc: Rodolfo Giometti , Ryan Govostes Subject: [PATCH v1 2/7] pps: clients: gpio: Use dev_err_probe() to avoid log noise Date: Tue, 16 Feb 2021 13:31:49 +0200 Message-Id: <20210216113154.70852-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210216113154.70852-1-andriy.shevchenko@linux.intel.com> References: <20210216113154.70852-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When GPIO APIs return -EPROBE_DEFER there is no need to print the message, especially taking into consideration that it may repeat several times. Use dev_err_probe() to avoid log noise in such cases. Signed-off-by: Andy Shevchenko --- drivers/pps/clients/pps-gpio.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/pps/clients/pps-gpio.c b/drivers/pps/clients/pps-gpio.c index f89c31aa66f1..78c9680e8063 100644 --- a/drivers/pps/clients/pps-gpio.c +++ b/drivers/pps/clients/pps-gpio.c @@ -110,19 +110,16 @@ static int pps_gpio_setup(struct platform_device *pdev) data->gpio_pin = devm_gpiod_get(&pdev->dev, NULL, /* request "gpios" */ GPIOD_IN); - if (IS_ERR(data->gpio_pin)) { - dev_err(&pdev->dev, - "failed to request PPS GPIO\n"); - return PTR_ERR(data->gpio_pin); - } + if (IS_ERR(data->gpio_pin)) + return dev_err_probe(&pdev->dev, PTR_ERR(data->gpio_pin), + "failed to request PPS GPIO\n"); data->echo_pin = devm_gpiod_get_optional(&pdev->dev, "echo", GPIOD_OUT_LOW); - if (IS_ERR(data->echo_pin)) { - dev_err(&pdev->dev, "failed to request ECHO GPIO\n"); - return PTR_ERR(data->echo_pin); - } + if (IS_ERR(data->echo_pin)) + return dev_err_probe(&pdev->dev, PTR_ERR(data->echo_pin), + "failed to request ECHO GPIO\n"); if (data->echo_pin) { ret = of_property_read_u32(np, -- 2.30.0