From: Dejin Zheng <zhengdejin5@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: corbet@lwn.net, jarkko.nikula@linux.intel.com,
mika.westerberg@linux.intel.com, rric@kernel.org,
bhelgaas@google.com, wsa@kernel.org, linux-doc@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-pci@vger.kernel.org,
kw@linux.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] i2c: designware: Use the correct name of device-managed function
Date: Wed, 17 Feb 2021 00:11:29 +0800 [thread overview]
Message-ID: <20210216161129.GA749996@nuc8i5> (raw)
In-Reply-To: <YCvZDTLYPOvg73lb@smile.fi.intel.com>
On Tue, Feb 16, 2021 at 04:39:09PM +0200, Andy Shevchenko wrote:
> On Tue, Feb 16, 2021 at 10:18:09PM +0800, Dejin Zheng wrote:
> > Use the new function pcim_alloc_irq_vectors() to allocate IRQ vectors,
> > the pcim_alloc_irq_vectors() function, an explicit device-managed version
> > of pci_alloc_irq_vectors(). If pcim_enable_device() has been called
> > before, then pci_alloc_irq_vectors() is actually a device-managed
> > function. It is used here as a device-managed function, So replace it
> > with pcim_alloc_irq_vectors().
>
> ...
>
> > - r = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES);
> > + r = pcim_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES);
> > if (r < 0)
> > return r;
>
> It's good, but now why do we have pci_free_irq_vectors() in the same file?
>
Done. and thank you for your careful inspection.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
next prev parent reply other threads:[~2021-02-16 16:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 14:18 [PATCH v2 0/4] Introduce pcim_alloc_irq_vectors() Dejin Zheng
2021-02-16 14:18 ` [PATCH v2 1/4] PCI: " Dejin Zheng
2021-02-16 14:40 ` Andy Shevchenko
2021-02-16 14:18 ` [PATCH v2 2/4] Documentation: devres: Add pcim_alloc_irq_vectors() Dejin Zheng
2021-02-16 14:18 ` [PATCH v2 3/4] i2c: designware: Use the correct name of device-managed function Dejin Zheng
2021-02-16 14:39 ` Andy Shevchenko
2021-02-16 16:11 ` Dejin Zheng [this message]
2021-02-16 14:18 ` [PATCH v2 4/4] i2c: thunderx: " Dejin Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210216161129.GA749996@nuc8i5 \
--to=zhengdejin5@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=jarkko.nikula@linux.intel.com \
--cc=kw@linux.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rric@kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox