From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4402FC433E0 for ; Thu, 18 Feb 2021 15:08:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2B4664EB7 for ; Thu, 18 Feb 2021 15:08:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230467AbhBRPGd (ORCPT ); Thu, 18 Feb 2021 10:06:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232366AbhBRMxP (ORCPT ); Thu, 18 Feb 2021 07:53:15 -0500 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7011C0613D6 for ; Thu, 18 Feb 2021 04:52:27 -0800 (PST) Received: by mail-pl1-x632.google.com with SMTP id e9so1214714plh.3 for ; Thu, 18 Feb 2021 04:52:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WtJG2gNtFvYKB4xLzXdqRCDe6hB+LE9X1M8Q+UfN854=; b=qsd6ryJkDj5inFk6cBr8fDz/aMqdlifJhMcipvy6+zAhzHeA9dvWs4qhOla9ZyeJWw R2rIusjUc0pU25Sw5TOxspkGtTSISes7AGFGvvJuwEi0zoulnf7MyStFjjnMutLr/eJq 4QidPwI8F0FmoKAwzsXgnW1tWRq3csUFXQrk0aQ4h1CJsqP6wbwkDwy4Rgt1y41dwq9d Y9HJ6i8td8CPvoT2vcm8Lwv9dnI26LhmFtRdLphwsKVzgDZo/d+7K85XYHY5g7ipV7e5 IJpV2qSe0aik9yqRABAMJ9TTFgEQxjhVBzz/E66lo3xRwQblEWuuup1sWZ44KM3B8qqs z5WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WtJG2gNtFvYKB4xLzXdqRCDe6hB+LE9X1M8Q+UfN854=; b=mLUEGY5vQu1U1cQhVLUZye+6J6wPWtiX5K06Vqc4YM+uHZdm+3PETh1UNgTkZsMLpV 1ugIK8RcDBvYRTAURmTn3Nc5OT4thgbEjvhP9xPIVC401Q43ALGBQmGWyMYnyP8LoMCu jJQY/M4BD3KFnkktcMqxXFNx/LJSxsxZzL9wbR0dLe8NGBsaz7YsBytogMDMsgkNfsSM cVEf7h8YBCXgs2P0gnyE9rXuXhI/xvwtchARk/4BrvccDyP5bbZnGjXu5CXrAoA1rnun 1NKjHELvR6d1mrjD4RKix95NBjo9Zoe0g57jO8zv9Nc0nfYTs47nbagBmvaJ27ilnWva bpbQ== X-Gm-Message-State: AOAM532cPSrGfqHc90jllyeazj5wcdcdgSENmHGWtHh8cIPNTRmS2PBy Ai5HMa7kwDWzjVtONBj5xQyASf8MnSc= X-Google-Smtp-Source: ABdhPJx3lZFklCVME3XvBfaJ8akaMuMBM2dR5+DuJNebs2SzT6FT60D6WqHwEGUqjKov5BSDw4TS1A== X-Received: by 2002:a17:90a:6bc5:: with SMTP id w63mr3919763pjj.28.1613652747397; Thu, 18 Feb 2021 04:52:27 -0800 (PST) Received: from atulu-nitro ([2401:4900:3155:553b:559f:4399:2a05:67d4]) by smtp.gmail.com with ESMTPSA id 184sm5976555pgj.93.2021.02.18.04.52.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Feb 2021 04:52:26 -0800 (PST) Date: Thu, 18 Feb 2021 18:22:20 +0530 From: Atul Gopinathan To: Greg KH Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] staging: comedi: cast function output to assigned variable type Message-ID: <20210218125220.GA19456@atulu-nitro> References: <20210218084404.16591-1-atulgopinathan@gmail.com> <8f73b7a1-02dd-32ef-8115-ad0f38868692@mev.co.uk> <20210218104755.GA7571@atulu-nitro> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 18, 2021 at 01:21:05PM +0100, Greg KH wrote: > On Thu, Feb 18, 2021 at 04:17:55PM +0530, Atul Gopinathan wrote: > > On Thu, Feb 18, 2021 at 10:31:15AM +0000, Ian Abbott wrote: > > > On 18/02/2021 08:44, Atul Gopinathan wrote: > > > > Fix the following warning generated by sparse: > > > > > > > > drivers/staging//comedi/comedi_fops.c:2956:23: warning: incorrect type in assignment (different address spaces) > > > > drivers/staging//comedi/comedi_fops.c:2956:23: expected unsigned int *chanlist > > > > drivers/staging//comedi/comedi_fops.c:2956:23: got void [noderef] * > > > > > > > > compat_ptr() has a return type of "void __user *" > > > > as defined in "include/linux/compat.h" > > > > > > > > cmd->chanlist is of type "unsigned int *" as defined > > > > in drivers/staging/comedi/comedi.h" in struct > > > > comedi_cmd. > > > > > > > > Signed-off-by: Atul Gopinathan > > > > --- > > > > drivers/staging/comedi/comedi_fops.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c > > > > index e85a99b68f31..fc4ec38012b4 100644 > > > > --- a/drivers/staging/comedi/comedi_fops.c > > > > +++ b/drivers/staging/comedi/comedi_fops.c > > > > @@ -2953,7 +2953,7 @@ static int get_compat_cmd(struct comedi_cmd *cmd, > > > > cmd->scan_end_arg = v32.scan_end_arg; > > > > cmd->stop_src = v32.stop_src; > > > > cmd->stop_arg = v32.stop_arg; > > > > - cmd->chanlist = compat_ptr(v32.chanlist); > > > > + cmd->chanlist = (unsigned int __force *)compat_ptr(v32.chanlist); > > > > cmd->chanlist_len = v32.chanlist_len; > > > > cmd->data = compat_ptr(v32.data); > > > > cmd->data_len = v32.data_len; > > > > > > > > > > This patch and the other one in your series clash with commit 9d5d041eebe3 > > > ("staging: comedi: comedi_fops.c: added casts to get rid of sparse > > > warnings") by B K Karthik. > > > > Oh I see. Not sure if this is the right place to ask, but which tree and > > branch should one work with when messing with the code in staging/ > > directory? (wanted to avoid such clashes in future) > > staging-next is the best one to use from the staging.git tree. But as > the above commit was merged in 5.9-rc1, way back in July of last year, I > have no idea what tree you are currently using to not hit that... I'm using the staging tree alright, cloned it yesterday. Except I used the --depth parameter. I believe that is the culprit. How bad a mistake is that? (Why depth? I'm currently staying in a remote area where internet download speeds are less than 100Kbps. I tried a normal git clone of the staging tree and it's estimated time was more than half a day. Not to mention, it fails due to loss of connection midway every time) Thanks! Atul