From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0136C433DB for ; Fri, 19 Feb 2021 09:12:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 290D964EB1 for ; Fri, 19 Feb 2021 09:12:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230231AbhBSJMk (ORCPT ); Fri, 19 Feb 2021 04:12:40 -0500 Received: from mail-lj1-f174.google.com ([209.85.208.174]:35713 "EHLO mail-lj1-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229656AbhBSJHc (ORCPT ); Fri, 19 Feb 2021 04:07:32 -0500 Received: by mail-lj1-f174.google.com with SMTP id a17so16457006ljq.2 for ; Fri, 19 Feb 2021 01:07:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4SYuc31NBuKizkQQlJfdfOc2gXxQ85QiVTeukEPxaJo=; b=LDfJwjT//iM9e7GQjotd14NXgXFfnBXi1fUnN/nq4ba/ZJtSKHke+TFqt8lkbe34XI 4T9aWaJL85Mz9kXgJACfvMqR3Y2TqnDBQE5dueFEyqwMdzr9O7vW38g20gA9KJw//1dr NaN/bd7qczDbTP5qMx5gaAqLC86kvHCnUrPGbOInYyY0MS86KyU6WwKYBDtINyANm1hF jGuj9YaEWoJHKd/zCj3fSGKbOKcs12/f9rUSRYmHD7WORDp9cEueGdfptlTMzkgvdUHG dDNEbLtHuOrLHgPhxwdBiG6JkRT/2hdBm+QqnQYylFzWYXopn/zbGf+WT/COlY1cQdYC G5/w== X-Gm-Message-State: AOAM53102d7SBBQ2lOsg4Tfb3FScGskFSByoaMHbLh68vNVRBQJzioxe Jf7+2p3AFiTpWsgMrUAfIqk= X-Google-Smtp-Source: ABdhPJyIr4pTFDSmke4G+1GbuqxxKbKpF9BGX1DDqXlPLYXDGwLdp2OQf47rvm9/PnFToJGmQhhu9A== X-Received: by 2002:a19:ae02:: with SMTP id f2mr4955335lfc.129.1613725608666; Fri, 19 Feb 2021 01:06:48 -0800 (PST) Received: from localhost.localdomain (broadband-188-32-236-56.ip.moscow.rt.ru. [188.32.236.56]) by smtp.googlemail.com with ESMTPSA id a10sm304097lfd.135.2021.02.19.01.06.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Feb 2021 01:06:48 -0800 (PST) From: Denis Efremov To: Julia Lawall Cc: Denis Efremov , cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org Subject: [PATCH v2 RESEND] coccinelle: misc: add minmax script Date: Fri, 19 Feb 2021 12:06:55 +0300 Message-Id: <20210219090655.8985-1-efremov@linux.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210216160326.1341741-1-efremov@linux.com> References: <20210216160326.1341741-1-efremov@linux.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Check for opencoded min(), max() implementations. Signed-off-by: Denis Efremov --- Changes in v2: - <... ...> instead of ... when any - org mode reports fixed - patch rule to drop excessive () scripts/coccinelle/misc/minmax.cocci | 224 +++++++++++++++++++++++++++ 1 file changed, 224 insertions(+) create mode 100644 scripts/coccinelle/misc/minmax.cocci diff --git a/scripts/coccinelle/misc/minmax.cocci b/scripts/coccinelle/misc/minmax.cocci new file mode 100644 index 000000000000..61d6b61fd82c --- /dev/null +++ b/scripts/coccinelle/misc/minmax.cocci @@ -0,0 +1,224 @@ +// SPDX-License-Identifier: GPL-2.0-only +/// +/// Check for opencoded min(), max() implementations. +/// Generated patches sometimes require adding a cast to fix compile warning. +/// Warnings/patches scope intentionally limited to a function body. +/// +// Confidence: Medium +// Copyright: (C) 2021 Denis Efremov ISPRAS +// Options: --no-includes --include-headers +// +// Keywords: min, max +// + + +virtual report +virtual org +virtual context +virtual patch + +@rmax depends on !patch@ +identifier func; +expression x, y; +binary operator cmp = {>, >=}; +position p; +@@ + +func(...) +{ + <... +* x cmp@p y ? x : y + ...> +} + +@rmaxif depends on !patch@ +identifier func; +expression x, y; +expression max_val; +binary operator cmp = {>, >=}; +position p; +@@ + +func(...) +{ + <... +* if (x cmp@p y) { +* max_val = x; +* } else { +* max_val = y; +* } + ...> +} + +@rmin depends on !patch@ +identifier func; +expression x, y; +binary operator cmp = {<, <=}; +position p; +@@ + +func(...) +{ + <... +* x cmp@p y ? x : y + ...> +} + +@rminif depends on !patch@ +identifier func; +expression x, y; +expression min_val; +binary operator cmp = {<, <=}; +position p; +@@ + +func(...) +{ + <... +* if (x cmp@p y) { +* min_val = x; +* } else { +* min_val = y; +* } + ...> +} + +@pmax depends on patch@ +identifier func; +expression x, y; +binary operator cmp = {>=, >}; +position p; +@@ + +func@p(...) +{ + <... +- x cmp y ? x : y ++ max(x, y) + ...> +} + +@pmaxif depends on patch@ +identifier func; +expression x, y; +expression max_val; +binary operator cmp = {>=, >}; +position p; +@@ + +func@p(...) +{ + <... +- if (x cmp y) { +- max_val = x; +- } else { +- max_val = y; +- } ++ max_val = max(x, y); + ...> +} + +@pmin depends on patch@ +identifier func; +expression x, y; +binary operator cmp = {<=, <}; +position p; +@@ + +func@p(...) +{ + <... +- x cmp y ? x : y ++ min(x, y) + ...> +} + +@pminif depends on patch@ +identifier func; +expression x, y; +expression min_val; +binary operator cmp = {<=, <}; +position p; +@@ + +func@p(...) +{ + <... +- if (x cmp y) { +- min_val = x; +- } else { +- min_val = y; +- } ++ min_val = min(x, y); + ...> +} + +@depends on (pmax || pmaxif || pmin || pminif)@ +identifier func; +expression x, y; +position p; +// FIXME: Coccinelle consumes all available ram and +// and timeouts on every file. +// position p = { pmin.p, pminif.p, pmax.p, pmaxif.p }; +@@ + +func@p(...) +{ + <... +( +- (min((x), (y))) ++ min(x, y) +| +- (max((x), (y))) ++ max(x, y) +) + ...> +} + +@script:python depends on report@ +p << rmax.p; +@@ + +coccilib.report.print_report(p[0], "WARNING opportunity for max()") + +@script:python depends on org@ +p << rmax.p; +@@ + +coccilib.org.print_todo(p[0], "WARNING opportunity for max()") + +@script:python depends on report@ +p << rmaxif.p; +@@ + +coccilib.report.print_report(p[0], "WARNING opportunity for max()") + +@script:python depends on org@ +p << rmaxif.p; +@@ + +coccilib.org.print_todo(p[0], "WARNING opportunity for max()") + +@script:python depends on report@ +p << rmin.p; +@@ + +coccilib.report.print_report(p[0], "WARNING opportunity for min()") + +@script:python depends on org@ +p << rmin.p; +@@ + +coccilib.org.print_todo(p[0], "WARNING opportunity for min()") + +@script:python depends on report@ +p << rminif.p; +@@ + +coccilib.report.print_report(p[0], "WARNING opportunity for min()") + +@script:python depends on org@ +p << rminif.p; +@@ + +coccilib.org.print_todo(p[0], "WARNING opportunity for min()") -- 2.26.2