From: Pavel Machek <pavel@ucw.cz>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
linux-leds@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH 1/2] leds: trigger: Fix error path to not unlock the unlocked mutex
Date: Fri, 19 Feb 2021 10:46:21 +0100 [thread overview]
Message-ID: <20210219094621.GA5641@duo.ucw.cz> (raw)
In-Reply-To: <20210219082955.5007-1-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 246 bytes --]
On Fri 2021-02-19 09:29:54, Uwe Kleine-König wrote:
> ttyname is allocated before the mutex is taken, so it must not be
> unlocked in the error path.
>
Acked-by: Pavel Machek <pavel@ucw.cz>
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2021-02-19 9:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 8:29 [PATCH 1/2] leds: trigger: Fix error path to not unlock the unlocked mutex Uwe Kleine-König
2021-02-19 8:29 ` [PATCH 2/2] leds: trigger/tty: Use led_set_brightness_sync() from workqueue Uwe Kleine-König
2021-02-19 9:46 ` Pavel Machek
2021-02-19 9:52 ` Uwe Kleine-König
2021-02-19 10:00 ` Pavel Machek
2021-02-19 10:41 ` Greg Kroah-Hartman
2021-02-19 11:23 ` Pavel Machek
2021-02-19 9:46 ` Pavel Machek [this message]
2021-02-19 10:38 ` [PATCH 1/2] leds: trigger: Fix error path to not unlock the unlocked mutex kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210219094621.GA5641@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox