From: Dan Carpenter <dan.carpenter@oracle.com>
To: Amrit Khera <amritkhera98@gmail.com>
Cc: gregkh@linuxfoundation.org, arve@android.com, tkjos@android.com,
maco@android.com, joel@joelfernandes.org, christian@brauner.io,
hridya@google.com, surenb@google.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: android: Fix const keyword style issue in ashmem.c
Date: Fri, 19 Feb 2021 15:04:58 +0300 [thread overview]
Message-ID: <20210219120457.GY2087@kadam> (raw)
In-Reply-To: <20210219114237.5720-1-amritkhera98@gmail.com>
On Fri, Feb 19, 2021 at 05:12:38PM +0530, Amrit Khera wrote:
> This change fixes a checkpatch warning for "struct file_operations
> should normally be const".
>
> Signed-off-by: Amrit Khera <amritkhera98@gmail.com>
> ---
> Changes in v2:
> - Wrapped the commit description
> - Build tested
^^^^^^^^^^^^
Heh. Nope.
This breaks the build.
regards,
dan carpenter
next prev parent reply other threads:[~2021-02-19 12:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 11:42 [PATCH v2] staging: android: Fix const keyword style issue in ashmem.c Amrit Khera
2021-02-19 12:04 ` Dan Carpenter [this message]
2021-02-19 12:12 ` Greg KH
2021-02-19 13:40 ` Amrit Khera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210219120457.GY2087@kadam \
--to=dan.carpenter@oracle.com \
--cc=amritkhera98@gmail.com \
--cc=arve@android.com \
--cc=christian@brauner.io \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hridya@google.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=surenb@google.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox