From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27A1FC433DB for ; Fri, 19 Feb 2021 12:13:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E4D4F64EB7 for ; Fri, 19 Feb 2021 12:13:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230332AbhBSMN0 (ORCPT ); Fri, 19 Feb 2021 07:13:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230079AbhBSMNU (ORCPT ); Fri, 19 Feb 2021 07:13:20 -0500 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4200FC061756 for ; Fri, 19 Feb 2021 04:12:40 -0800 (PST) Received: by mail-pl1-x62d.google.com with SMTP id k22so3260384pll.6 for ; Fri, 19 Feb 2021 04:12:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fr73k0oFNcOMq5EUpeQYfmWohZLzAZP/+I818Q2oXuY=; b=kbRqUBNjEh6WC4dMLAAMumlsH02hDzKSgaicJoO3BeUC1yL5Wuk9VNVh0ZCs0bIeJu fC3gb1qW3dMb8zF20fAgDn/O7tYQHfiU26QLvf11TiaIoehOFHLqSS5CLLZNsvgEnpz3 uwbFspDdkfiws7cDA2/aV2Y+tzAe2qwmfQNLEH0ILgjHe4aesc/hZ5LDU555BoCht1hn rUWzICGzdc5PvRaCLrGigFvhOYreenaWiBk7lvlzYyQ31ZSV7GODRM8m9ZKGBoyx58cI L0aBuJ4VXEUQwZgopv+mVNUgBiPEB3heR9RTve/5wR5hDpUlXGRd2oxhn/Hh4yGN7UZE TyFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fr73k0oFNcOMq5EUpeQYfmWohZLzAZP/+I818Q2oXuY=; b=UccMxTYty53fA+ZXfak+8CgkPeytHCqGdf+4oWtYJOcQVyrb8+yAtaKa05Na3Znh42 Ll8l4CREo+9hFMMilMhKvB3liHSbqSNKg1Zca9hm/EkoPdsMnuJX6WYJEquk9VtpUnZO yUiBXV0fc5ljxbkguH9qqiVfGWp4q2HQ7QrCQ+eZxcSVbxsg8aamEVqNxSkYOBeQKdk0 JeeFovUO/j3V3DoE/pz2mt1Hd8aymVjJbUgCxCCgjFJX2TKFU+jtQfDiQDUOPl1YwVG8 9ySAqPDmo1Fcm/B2oO28xkf8afhKPtxt30bx8BAbkY+yFNhSjd47h4B95ZcEDYDKTCJg gc+A== X-Gm-Message-State: AOAM533GinsR3CKmIOebHj9jNSUek5Lce0ICwcYdGKGSZkJG21YJ5YER T4wscm6uONZWo0XMviDmnmE= X-Google-Smtp-Source: ABdhPJxL4SZltxfc5BhDYGRd70PqUkr0oHOaHi8XUXUffDyYYhA+8Nn0boYhejfQNmZ/4Z6nb2SA5g== X-Received: by 2002:a17:90a:1a0b:: with SMTP id 11mr8708576pjk.58.1613736759769; Fri, 19 Feb 2021 04:12:39 -0800 (PST) Received: from gmail.com ([2401:4900:3847:831e:690e:964b:81e9:e810]) by smtp.gmail.com with ESMTPSA id c29sm2608427pgb.58.2021.02.19.04.12.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Feb 2021 04:12:39 -0800 (PST) Date: Fri, 19 Feb 2021 17:42:33 +0530 From: Prakash Dubey To: Dan Carpenter Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: fwserial: Fix alignment of function parameters Message-ID: <20210219121233.GA16568@gmail.com> References: <20210218102851.GA20810@gmail.com> <20210219115221.GW2087@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210219115221.GW2087@kadam> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 19, 2021 at 02:52:21PM +0300, Dan Carpenter wrote: > On Fri, Feb 19, 2021 at 11:39:27AM +0100, Greg KH wrote: > > On Fri, Feb 19, 2021 at 03:25:38PM +0530, 17UCS047_Prakash Dubey wrote: > > > I was unable to align it right below the opening parenthesis, just by using > > > tabs. And when I did that with spaces, the checkpatch yelled at me for > > > using spaces. Any suggestions how to do this without using spaces? I am > > > using vim, I will try to find a workaround meanwhile. > > > > Your comment hasn't made it to the list yet. Sometimes there is a delay > or maybe it was blocked for some reason (html email?). > > You are allowed to use spaces but you can't have 8 consecutive spaces > and spaces are not allowed before a tab character. The way to align it > is: > > ret = wait_event_interruptible_timeout(port->wait_tx, > !test_bit(IN_TX, &port->flags), > 10); > > [tab x6][space x7]!test_bit(IN_TX, &port->flags) > > regards, > dan carpenter Thank you Dan, I figured that out after a few failed attempts to align properly. I was replying through Gmail web client, as I am new to mutt. I am getting the hang of it. -- Regards, Prakash