From: Dan Carpenter <dan.carpenter@oracle.com>
To: Amrit Khera <amritkhera98@gmail.com>
Cc: gregkh@linuxfoundation.org, lee.jones@linaro.org, arnd@arndb.de,
johannes@sipsolutions.net, kuba@kernel.org, mail@anirudhrb.com,
memxor@gmail.com, rdunlap@infradead.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: wimax: Fix block comment style issue in stack.c
Date: Mon, 22 Feb 2021 09:15:59 +0300 [thread overview]
Message-ID: <20210222061559.GK2087@kadam> (raw)
In-Reply-To: <20210221163758.2996-1-amritkhera98@gmail.com>
On Sun, Feb 21, 2021 at 10:07:59PM +0530, Amrit Khera wrote:
> diff --git a/drivers/staging/wimax/stack.c b/drivers/staging/wimax/stack.c
> index ace24a6dfd2d..345a022810ef 100644
> --- a/drivers/staging/wimax/stack.c
> +++ b/drivers/staging/wimax/stack.c
> @@ -57,17 +57,7 @@ MODULE_PARM_DESC(debug,
>
> /*
> * Authoritative source for the RE_STATE_CHANGE attribute policy
Delete the whole comment. This sentence doesn't make any sense by
itself once we have removed the rest.
> - *
> - * We don't really use it here, but /me likes to keep the definition
> - * close to where the data is generated.
> */
> -/*
> -static const struct nla_policy wimax_gnl_re_status_change[WIMAX_GNL_ATTR_MAX + 1] = {
> - [WIMAX_GNL_STCH_STATE_OLD] = { .type = NLA_U8 },
> - [WIMAX_GNL_STCH_STATE_NEW] = { .type = NLA_U8 },
> -};
regards,
dan carpenter
prev parent reply other threads:[~2021-02-22 6:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-21 16:37 [PATCH v2] staging: wimax: Fix block comment style issue in stack.c Amrit Khera
2021-02-21 18:09 ` Greg KH
2021-02-22 6:15 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210222061559.GK2087@kadam \
--to=dan.carpenter@oracle.com \
--cc=amritkhera98@gmail.com \
--cc=arnd@arndb.de \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@anirudhrb.com \
--cc=memxor@gmail.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox