From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB5CEC433E0 for ; Mon, 22 Feb 2021 15:59:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B115C64EF2 for ; Mon, 22 Feb 2021 15:59:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230446AbhBVP7p (ORCPT ); Mon, 22 Feb 2021 10:59:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230379AbhBVP7a (ORCPT ); Mon, 22 Feb 2021 10:59:30 -0500 Received: from mail-qt1-x82b.google.com (mail-qt1-x82b.google.com [IPv6:2607:f8b0:4864:20::82b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95F64C06174A for ; Mon, 22 Feb 2021 07:58:47 -0800 (PST) Received: by mail-qt1-x82b.google.com with SMTP id c1so9573266qtc.1 for ; Mon, 22 Feb 2021 07:58:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=n07VaxTY0kbB+VdtG9ROy4sSSmPU2dRQLBzVM0ZBz7E=; b=Yqh1ikPAu5/XDu3ob7bxG4ON5Ojvl2kXbVvCYH8A3EXSyCxNXlgTurFsl7mfTra0X4 O8wd/nDs2txIH9cGahzAJmgTOApJ4luniDPCNv1PaqGgw2vf6VZ33bO1/YpHbaqowXzK EiBfnce60ipXhW9OI8r/P3xjfbuLK6MpavM+F5k4Fr4ynqNo19p62ZykbRtWyyytjb6N 96T0vEmI9qBNlae3pTyJkDyZt20F7aF57Pb5TJWwSujuToukmDfa3joBNW9PM8oVy3kG kPRW5BM+QC00dNZfyDkUMMYyT+spJAOUYvMdkp2P98MaoDFZ67Pp/+DLr0OIleZbNC+p Xzvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=n07VaxTY0kbB+VdtG9ROy4sSSmPU2dRQLBzVM0ZBz7E=; b=cHTl9yVC/ybucWiGmkSt3RapuZsUwsee7GAtxU6uJcbSIENyvZ2e3+hEuzxcXdWVBf 64WAyWvemmK23u+PmclY4s7lV9v0LaVplhpaCAvmqL4auNgFT0/3OHlpqbqDYTZcaKpE eqGpcLsgyd/mctMoHdpEsG09k3Y3c4GzVHXqHXvlj6wUrcYBKF7hs7zLNj7a90F6j6du TgyDokgtogkrWjyAB4N7jdTJlfkRAUKtKIzJgkCeNl1KomcwlnPGtjPYAjwR5qwGD7Ii ee8xNYNWYdc5BxPhjCdou2HBdb536RFcLc71ZU68gvSM4yXMvDk9Jnkjc02hr52TkntH 8gWg== X-Gm-Message-State: AOAM533F7ihqUGS704T8i0drx6B7+wQLNQEQwxmDyj14FIMyFS2nBRyj TWHAeMVgWGJIewnPcTjTCh/Jow== X-Google-Smtp-Source: ABdhPJyby2lV/pkUjOuAGtzhFcBs3hQo43DMUoohhVtah90nJbhZYkzBQWWSi40FRSmcZMEGzEaHjA== X-Received: by 2002:a05:622a:143:: with SMTP id v3mr20662916qtw.363.1614009526850; Mon, 22 Feb 2021 07:58:46 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-115-133.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.115.133]) by smtp.gmail.com with ESMTPSA id x12sm12175675qkj.20.2021.02.22.07.58.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Feb 2021 07:58:46 -0800 (PST) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1lEDbh-00ERHh-Or; Mon, 22 Feb 2021 11:58:45 -0400 Date: Mon, 22 Feb 2021 11:58:45 -0400 From: Jason Gunthorpe To: Leon Romanovsky , Arnd Bergmann Cc: Zhu Yanjun , Julian Braha , Doug Ledford , RDMA mailing list , LKML Subject: Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO Message-ID: <20210222155845.GI2643399@ziepe.ca> References: <21525878.NYvzQUHefP@ubuntu-mate-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 22, 2021 at 03:00:03PM +0200, Leon Romanovsky wrote: > On Mon, Feb 22, 2021 at 10:39:20AM +0800, Zhu Yanjun wrote: > > On Sun, Feb 21, 2021 at 2:49 PM Leon Romanovsky wrote: > > > > > > On Fri, Feb 19, 2021 at 06:32:26PM -0500, Julian Braha wrote: > > > > commit 6e61907779ba99af785f5b2397a84077c289888a > > > > Author: Julian Braha > > > > Date: Fri Feb 19 18:20:57 2021 -0500 > > > > > > > > drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO > > > > > > > > When RDMA_RXE is enabled and CRYPTO is disabled, > > > > Kbuild gives the following warning: > > > > > > > > WARNING: unmet direct dependencies detected for CRYPTO_CRC32 > > > > Depends on [n]: CRYPTO [=n] > > > > Selected by [y]: > > > > - RDMA_RXE [=y] && (INFINIBAND_USER_ACCESS [=y] || !INFINIBAND_USER_ACCESS [=y]) && INET [=y] && PCI [=y] && INFINIBAND [=y] && INFINIBAND_VIRT_DMA [=y] > > > > > > > > This is because RDMA_RXE selects CRYPTO_CRC32, > > > > without depending on or selecting CRYPTO, despite that config option > > > > being subordinate to CRYPTO. > > > > > > > > Signed-off-by: Julian Braha > > > > > > Please use git sent-email to send patches and please fix crypto Kconfig > > > to enable CRYPTO if CRYPTO_* selected. > > > > > > It is a little bit awkward to request all users of CRYPTO_* to request > > > select CRYPTO too. > > > > The same issue and similar patch is in this link: > > > > https://patchwork.kernel.org/project/linux-rdma/patch/20200915101559.33292-1-fazilyildiran@gmail.com/#23615747 > > So what prevents us from fixing CRYPTO Kconfig? Yes, I would like to see someone deal with this properly, either every place doing select CRYPTO_XX needs fixing or something needs to be done in the crypto layer. I have no idea about kconfig to give advice, I've added Arnd since he always seems to know :) Thanks, Jason