From: "Pali Rohár" <pali@kernel.org>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>,
Dan Murphy <dmurphy@ti.com>, Sebastian Reichel <sre@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
maemo-leste@lists.dyne.org
Subject: Re: [PATCH 1/3] power: supply: bq27xxx: fix sign of current_now for newer ICs
Date: Tue, 23 Feb 2021 15:53:35 +0100 [thread overview]
Message-ID: <20210223145335.2vsfclgeqpsmacfp@pali> (raw)
In-Reply-To: <20210223154946.1ef58514@aktux>
On Tuesday 23 February 2021 15:49:46 Andreas Kemnade wrote:
> On Tue, 23 Feb 2021 15:11:20 +0100
> Matthias Schiffer <matthias.schiffer@ew.tq-group.com> wrote:
>
> > Commit cd060b4d0868 ("power: supply: bq27xxx: fix polarity of current_now")
> > changed the sign of current_now for all bq27xxx variants, but on BQ28Z610
> > I'm now seeing negated values *with* that patch.
> >
> > The GTA04/Openmoko device that was used for testing uses a BQ27000 or
> > BQ27010 IC, so I assume only the BQ27XXX_O_ZERO code path was incorrect.
> > Revert the behaviour for newer ICs.
> >
> > Fixes: cd060b4d0868 "power: supply: bq27xxx: fix polarity of current_now"
> > Signed-off-by: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> > ---
> >
> > @Andreas Kemnade: It would be great to get a confirmation that the
> > Openmoko battery indeed uses BQ27000/BQ27010 - I was having some trouble
> > finding that information.
> >
> I can confirm that.
> here is the corresponding schematic:
>
> http://people.openmoko.org/tony_tu/GTA02/hardware/GTA02/CT-GTA02.pdf
>
> Regards,
> Andreas
Nokia N900 has BQ27200 connected via i2c. CCing Maemo mailing list maemo-leste@lists.dyne.org
prev parent reply other threads:[~2021-02-23 14:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 14:11 [PATCH 1/3] power: supply: bq27xxx: fix sign of current_now for newer ICs Matthias Schiffer
2021-02-23 14:11 ` [PATCH 2/3] power: supply: bq27xxx: fix power_avg Matthias Schiffer
2021-02-24 11:50 ` Matthias Schiffer
2021-02-23 14:11 ` [PATCH 3/3] power: supply: bq27xxx: make status more robust Matthias Schiffer
2021-02-23 14:49 ` [PATCH 1/3] power: supply: bq27xxx: fix sign of current_now for newer ICs Andreas Kemnade
2021-02-23 14:53 ` Pali Rohár [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210223145335.2vsfclgeqpsmacfp@pali \
--to=pali@kernel.org \
--cc=andreas@kemnade.info \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=maemo-leste@lists.dyne.org \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox