From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 268B1C433E0 for ; Tue, 23 Feb 2021 14:54:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D8E5764E12 for ; Tue, 23 Feb 2021 14:54:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232594AbhBWOyZ (ORCPT ); Tue, 23 Feb 2021 09:54:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:53364 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232520AbhBWOyS (ORCPT ); Tue, 23 Feb 2021 09:54:18 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id ED19164E12; Tue, 23 Feb 2021 14:53:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614092018; bh=OM4cSQCV8yXeiUPJwhUhjpxUXGQYw13IEBaq41dXDGM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZGU+j7EQQ2t8KbwUIJxd7loy8zUA1jLuw2dGQPrVXAcKUzwFESYQF6diMDL3UIGZ8 UpLCPAo62vTnHkKlD7vElszn1Hozun4b7rONR8m23vSVN+XyhTqkV05LEWizHkz2VU m1uaEPgtWWq7+vMuREIBY6ZQIEXDTSt8R2I1d3qdn4YRQ4fGe2piacu9m7c0z9vydo Q3eYvn1NPlPojp1YJyLZv2Vs7PFj7QaOfgGdBEFpCPBq+/FpcDYV0kgQPfjOPjF0eT cnh06GLAwVXD8n2HED9ORMQow6kAZfLHMLndv7/MGi904o9Hkv3RIKyHGLuMVBIH6i SzQJuPcsa28xw== Received: by pali.im (Postfix) id A00E2CAE; Tue, 23 Feb 2021 15:53:35 +0100 (CET) Date: Tue, 23 Feb 2021 15:53:35 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Andreas Kemnade Cc: Matthias Schiffer , Dan Murphy , Sebastian Reichel , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, maemo-leste@lists.dyne.org Subject: Re: [PATCH 1/3] power: supply: bq27xxx: fix sign of current_now for newer ICs Message-ID: <20210223145335.2vsfclgeqpsmacfp@pali> References: <20210223141122.9574-1-matthias.schiffer@ew.tq-group.com> <20210223154946.1ef58514@aktux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210223154946.1ef58514@aktux> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 23 February 2021 15:49:46 Andreas Kemnade wrote: > On Tue, 23 Feb 2021 15:11:20 +0100 > Matthias Schiffer wrote: > > > Commit cd060b4d0868 ("power: supply: bq27xxx: fix polarity of current_now") > > changed the sign of current_now for all bq27xxx variants, but on BQ28Z610 > > I'm now seeing negated values *with* that patch. > > > > The GTA04/Openmoko device that was used for testing uses a BQ27000 or > > BQ27010 IC, so I assume only the BQ27XXX_O_ZERO code path was incorrect. > > Revert the behaviour for newer ICs. > > > > Fixes: cd060b4d0868 "power: supply: bq27xxx: fix polarity of current_now" > > Signed-off-by: Matthias Schiffer > > --- > > > > @Andreas Kemnade: It would be great to get a confirmation that the > > Openmoko battery indeed uses BQ27000/BQ27010 - I was having some trouble > > finding that information. > > > I can confirm that. > here is the corresponding schematic: > > http://people.openmoko.org/tony_tu/GTA02/hardware/GTA02/CT-GTA02.pdf > > Regards, > Andreas Nokia N900 has BQ27200 connected via i2c. CCing Maemo mailing list maemo-leste@lists.dyne.org