From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB8C4C433E0 for ; Wed, 24 Feb 2021 08:31:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F46064DE0 for ; Wed, 24 Feb 2021 08:31:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234047AbhBXIbQ (ORCPT ); Wed, 24 Feb 2021 03:31:16 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:34734 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233146AbhBXIax (ORCPT ); Wed, 24 Feb 2021 03:30:53 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 5BA741C0B81; Wed, 24 Feb 2021 09:29:55 +0100 (CET) Date: Wed, 24 Feb 2021 09:29:54 +0100 From: Pavel Machek To: Stefano Garzarella Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Jason Wang , "Michael S. Tsirkin" Subject: Re: [PATCH 5.10 03/29] vdpa_sim: store parsed MAC address in a buffer Message-ID: <20210224082954.GB8058@amd> References: <20210222121019.444399883@linuxfoundation.org> <20210222121020.153222666@linuxfoundation.org> <20210222195414.GA24405@amd> <20210223080655.ps7ujvgvs6wtlszf@steredhat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ZoaI/ZTpAVc4A5k6" Content-Disposition: inline In-Reply-To: <20210223080655.ps7ujvgvs6wtlszf@steredhat> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ZoaI/ZTpAVc4A5k6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > >>+++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c > >>@@ -42,6 +42,8 @@ static char *macaddr; > >> module_param(macaddr, charp, 0); > >> MODULE_PARM_DESC(macaddr, "Ethernet MAC address"); > >> > >>+u8 macaddr_buf[ETH_ALEN]; > >>+ > > > >Should this be static? >=20 > Yes, there is already a patch [1] queued by Michael but not yet upstream. > When it will be merged upstream I will make sure it will be backported. Having it in mainline is enough, I don't really think it causes anything user-visible, so it does not need to be in stable. Best regards, Pavel --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany --ZoaI/ZTpAVc4A5k6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmA2DoIACgkQMOfwapXb+vLgNACgj1vpwEzOIwV7Y/g16yUsIzIt nXAAoLMothbUEz/o+N8pICvYVwEgfNz7 =HZ2x -----END PGP SIGNATURE----- --ZoaI/ZTpAVc4A5k6--