Re: [PATCH V3 4/5] net: ethernet: ravb: Enable optional refclk

Andrew Lunn
2021-02-24T14:56:58Z

> @@ -2260,6 +2267,9 @@ static int ravb_remove(struct platform_device *pdev)
> if (priv->chip_id != RCAR_GEN2)
> ravb_ptp_stop(ndev);
>
> + if (priv->refclk)
> + clk_disable_unprepare(priv->refclk);
> +

Hi Adam

You don't need the if (). The clk API is happy with a NULL pointer and
will do the right thing. Otherwise:

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

Andrew