From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27165C43603 for ; Wed, 24 Feb 2021 14:17:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D4DE964E7A for ; Wed, 24 Feb 2021 14:17:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236204AbhBXOPw (ORCPT ); Wed, 24 Feb 2021 09:15:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:59786 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232726AbhBXNKf (ORCPT ); Wed, 24 Feb 2021 08:10:35 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9AE6264D8F; Wed, 24 Feb 2021 12:55:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614171318; bh=Hodl3P/Z2rwYON5zwFKUkrcQzjWsue/ipAK5ILCslgs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=D7VwWLKXvMhEi7yMvbVqzotUP8GuubbIOzFpWi/p8DpLG1eIhNm2oY6AruF/Rs2Zu K1tH07o9qdvrDG7QHj8cQpx3f8vv/x+/gPe1bStgqUcUrOLDgW6jj4cdvEFHzI9fPt whXKaKkke9ApshFIas46dGzY2zSNA8kCbX2V0p5iDHAGR/JBaLqFhs+MxTPJXObLCj ifwc17lnO2iO/jjnijb1ed0cfsqkRpq50ON9PiI8HB7lHL8AJwfWqNtxKoU20p6uNR KNh38puKT8aa6NPvjwaxL1VuL0KLqK1vGVkKR/Ss/O4oMHxW4DdN0+f4hPg7PNRrRt KEXIZy5h21HuQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jiri Slaby , Greg Kroah-Hartman , Sasha Levin Subject: [PATCH AUTOSEL 4.14 03/16] vt/consolemap: do font sum unsigned Date: Wed, 24 Feb 2021 07:55:00 -0500 Message-Id: <20210224125514.483935-3-sashal@kernel.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210224125514.483935-1-sashal@kernel.org> References: <20210224125514.483935-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jiri Slaby [ Upstream commit 9777f8e60e718f7b022a94f2524f967d8def1931 ] The constant 20 makes the font sum computation signed which can lead to sign extensions and signed wraps. It's not much of a problem as we build with -fno-strict-overflow. But if we ever decide not to, be ready, so switch the constant to unsigned. Signed-off-by: Jiri Slaby Link: https://lore.kernel.org/r/20210105120239.28031-7-jslaby@suse.cz Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/vt/consolemap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/vt/consolemap.c b/drivers/tty/vt/consolemap.c index a5f88cf0f61d5..a2c1a02f04078 100644 --- a/drivers/tty/vt/consolemap.c +++ b/drivers/tty/vt/consolemap.c @@ -493,7 +493,7 @@ con_insert_unipair(struct uni_pagedir *p, u_short unicode, u_short fontpos) p2[unicode & 0x3f] = fontpos; - p->sum += (fontpos << 20) + unicode; + p->sum += (fontpos << 20U) + unicode; return 0; } -- 2.27.0