From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D05BC433DB for ; Wed, 24 Feb 2021 21:03:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4255564E60 for ; Wed, 24 Feb 2021 21:03:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235885AbhBXVDR (ORCPT ); Wed, 24 Feb 2021 16:03:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235846AbhBXVDK (ORCPT ); Wed, 24 Feb 2021 16:03:10 -0500 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B7DEC061756 for ; Wed, 24 Feb 2021 13:02:30 -0800 (PST) Received: by mail-pg1-x52b.google.com with SMTP id o10so2320734pgg.4 for ; Wed, 24 Feb 2021 13:02:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4SvlU/VPC3jitNMDFCoTdqUmM2ems/SUz1e3P7eEQk8=; b=SYlpN8qNejqUuVmTxma7IIbHRieuWsqqi0lJCa8ykjPWjpAK9ezSrITp7k9r0KcJ0n 1seoBdkqKTnw2Nj9nD4RS8s1swSaatRMA1HbOKTVpbaqXpnMcK2rU71vPN0HO522+Pnt S4jpK5AwG+5gwWq1FFkBH1RcJ7NZEvIpYx2lI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4SvlU/VPC3jitNMDFCoTdqUmM2ems/SUz1e3P7eEQk8=; b=EY6huKl7Yp+ExRc3fPZMITGSAXEjSvLALbBGg8QTVV06ehRXAogDLYVmxqliOgNffd dwRcYam0A/7bmOxUNGNpJBdOm7thtgE495cpTL8GYhPQ0oiUJrHXxZPb2bTSS5YbFY56 aazus8bOZbzaezwjxLS2SP/BjX7FbT6p4KOkCL4JMDTNYUs5+yJSqMCCBeUgzxFChdE8 o1CFdAKxg9qc6+ffdnymfgQqRJwBgmEThjTS6o/7ZvdBwUcJ2RBG/XcV7kd/KWvDcFfI xJL2ZWs4ule70s9tYWIp1xNtd68jrv0f64hdiSGjltjDxqGwvApRh3D7dCjz63mu/9Ux 8Vnw== X-Gm-Message-State: AOAM531PuPfuenl+YLyVNNQqs2AQMhqHa4CQbL8eGJ7TMjhlcxc8YpTa 72+YnM8E6A1W7c/hS+quREgfIQ== X-Google-Smtp-Source: ABdhPJz66XN4j2LpwPuoy3e6mwQZLmn2HaozrxHR8+LnUzKBiVoxMW84WCO4p1plsgRGBhl00k+6Og== X-Received: by 2002:a62:7c15:0:b029:1ed:9e29:5998 with SMTP id x21-20020a627c150000b02901ed9e295998mr16836549pfc.22.1614200549528; Wed, 24 Feb 2021 13:02:29 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id e24sm3558427pjr.13.2021.02.24.13.02.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Feb 2021 13:02:28 -0800 (PST) Date: Wed, 24 Feb 2021 13:02:27 -0800 From: Kees Cook To: Sami Tolvanen Cc: "James E.J. Bottomley" , Helge Deller , Guenter Roeck , "Steven Rostedt (VMware)" , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] parisc: select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY Message-ID: <202102241301.226812E88@keescook> References: <20210224205938.4104543-1-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210224205938.4104543-1-samitolvanen@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 24, 2021 at 12:59:38PM -0800, Sami Tolvanen wrote: > parisc uses -fpatchable-function-entry with dynamic ftrace, which means we > don't need recordmcount. Select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY > to tell that to the build system. > > Reported-by: Guenter Roeck > Fixes: 3b15cdc15956 ("tracing: move function tracer options to Kconfig") > Signed-off-by: Sami Tolvanen I've got parisc building now, and can confirm: Tested-by: Kees Cook Guenter, does this fix it for you too? -Kees > --- > arch/parisc/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/parisc/Kconfig b/arch/parisc/Kconfig > index ecef9aff9d72..9ee806f68123 100644 > --- a/arch/parisc/Kconfig > +++ b/arch/parisc/Kconfig > @@ -60,6 +60,7 @@ config PARISC > select HAVE_KPROBES > select HAVE_KRETPROBES > select HAVE_DYNAMIC_FTRACE if $(cc-option,-fpatchable-function-entry=1,1) > + select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY if HAVE_DYNAMIC_FTRACE > select HAVE_FTRACE_MCOUNT_RECORD if HAVE_DYNAMIC_FTRACE > select HAVE_KPROBES_ON_FTRACE > select HAVE_DYNAMIC_FTRACE_WITH_REGS > > base-commit: 719bbd4a509f403f537adcaefd8ce17532be2e84 > -- > 2.30.0.617.g56c4b15f3c-goog > -- Kees Cook