From: Arnd Bergmann <arnd@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
DENG Qingfang <dqfext@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Landen Chao <landen.chao@mediatek.com>,
Sean Wang <sean.wang@mediatek.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] net: dsa: mt7530: add GPIOLIB dependency
Date: Thu, 25 Feb 2021 15:38:33 +0100 [thread overview]
Message-ID: <20210225143910.3964364-3-arnd@kernel.org> (raw)
In-Reply-To: <20210225143910.3964364-1-arnd@kernel.org>
From: Arnd Bergmann <arnd@arndb.de>
The new gpio support may be optional at runtime, but it requires
building against gpiolib:
ERROR: modpost: "gpiochip_get_data" [drivers/net/dsa/mt7530.ko] undefined!
ERROR: modpost: "devm_gpiochip_add_data_with_key" [drivers/net/dsa/mt7530.ko] undefined!
Add a Kconfig dependency to enforce this.
Fixes: 429a0edeefd8 ("net: dsa: mt7530: MT7530 optional GPIO support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/dsa/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/dsa/Kconfig b/drivers/net/dsa/Kconfig
index 3af373e90806..07fc2a732597 100644
--- a/drivers/net/dsa/Kconfig
+++ b/drivers/net/dsa/Kconfig
@@ -37,6 +37,7 @@ config NET_DSA_LANTIQ_GSWIP
config NET_DSA_MT7530
tristate "MediaTek MT753x and MT7621 Ethernet switch support"
depends on NET_DSA
+ depends on GPIOLIB
select NET_DSA_TAG_MTK
help
This enables support for the MediaTek MT7530, MT7531, and MT7621
--
2.29.2
next prev parent reply other threads:[~2021-02-25 14:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 14:38 [PATCH 1/3] net: mscc: ocelot: select NET_DEVLINK Arnd Bergmann
2021-02-25 14:38 ` [PATCH 2/3] net: dsa: tag_ocelot_8021q: fix driver dependency Arnd Bergmann
2021-02-25 14:43 ` Vladimir Oltean
2021-02-25 14:47 ` Arnd Bergmann
2021-02-25 14:49 ` Arnd Bergmann
2021-02-25 15:07 ` Vladimir Oltean
2021-02-25 15:43 ` Arnd Bergmann
2021-02-26 21:31 ` Vladimir Oltean
2021-02-25 14:38 ` Arnd Bergmann [this message]
2021-02-25 15:52 ` [PATCH 3/3] net: dsa: mt7530: add GPIOLIB dependency DENG Qingfang
2021-02-25 16:14 ` Arnd Bergmann
2021-02-26 23:36 ` [PATCH 1/3] net: mscc: ocelot: select NET_DEVLINK Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210225143910.3964364-3-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=landen.chao@mediatek.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox