From: Bjorn Helgaas <helgaas@kernel.org>
To: "Kuppuswamy,
Sathyanarayanan" <sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: "Arnd Bergmann" <arnd@kernel.org>,
"Robert Richter" <rric@kernel.org>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Arnd Bergmann" <arnd@arndb.de>, "Rob Herring" <robh@kernel.org>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Sean V Kelley" <sean.v.kelley@intel.com>,
"Qiuxu Zhuo" <qiuxu.zhuo@intel.com>,
"David E. Box" <david.e.box@linux.intel.com>,
"Yicong Yang" <yangyicong@hisilicon.com>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] PCI: controller: thunder: fix compile testing
Date: Thu, 25 Feb 2021 12:51:00 -0600 [thread overview]
Message-ID: <20210225185100.GA17711@bjorn-Precision-5520> (raw)
In-Reply-To: <de0dd513-dc7d-d7ca-c0b6-4bc9db355a53@linux.intel.com>
On Thu, Feb 25, 2021 at 09:44:12AM -0800, Kuppuswamy, Sathyanarayanan wrote:
> On 2/25/21 6:37 AM, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > Compile-testing these drivers is currently broken. Enabling
> > it causes a couple of build failures though:
> >
> > drivers/pci/controller/pci-thunder-ecam.c:119:30: error: shift count >= width of type [-Werror,-Wshift-count-overflow]
> > drivers/pci/controller/pci-thunder-pem.c:54:2: error: implicit declaration of function 'writeq' [-Werror,-Wimplicit-function-declaration]
> > drivers/pci/controller/pci-thunder-pem.c:392:8: error: implicit declaration of function 'acpi_get_rc_resources' [-Werror,-Wimplicit-function-declaration]
> >
> > Fix them with the obvious one-line changes.
> Looks good to me.
Thanks for looking this over! I'd like to acknowledge your review,
but I need an explicit Reviewed-by or similar. I don't want to put
words in your mouth by converting "Looks good to me" to "Reviewed-by".
next prev parent reply other threads:[~2021-02-25 18:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 14:37 [PATCH 1/2] PCI: controller: thunder: fix compile testing Arnd Bergmann
2021-02-25 14:37 ` [PATCH 2/2] PCI: controller: avoid building empty drivers Arnd Bergmann
2021-02-26 19:08 ` Robert Richter
2021-02-27 12:31 ` Arnd Bergmann
2021-02-25 17:44 ` [PATCH 1/2] PCI: controller: thunder: fix compile testing Kuppuswamy, Sathyanarayanan
2021-02-25 18:51 ` Bjorn Helgaas [this message]
2021-02-25 19:15 ` Kuppuswamy, Sathyanarayanan
2021-02-26 15:12 ` Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210225185100.GA17711@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=david.e.box@linux.intel.com \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=qiuxu.zhuo@intel.com \
--cc=robh@kernel.org \
--cc=rric@kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=sean.v.kelley@intel.com \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox