Re: [PATCH] staging: rtl8192e: Fix possible buffer overflow in _rtl92e_wx_set_scan

Lee
2021-03-05T15:01:17Z

Hi Dan,

Do you think any of these could be potential issues:

driver/staging/

rtl8192e/rtllib_rx.c:2442
wlan-ng/cfg80211.c:316
rtl8723bs/os_dep/ioctl_cfg80211.c:1591
rtl8723bs/os_dep/ioctl_cfg80211.c:2738

and if so, findable via Smatch?

Regards,
Lee

On Fri, Mar 05, 2021 at 11:22:28AM +0300, Dan Carpenter wrote:
> Actually, I looked through a bunch of these and they're mostly false
> positives outside of staging. I guess there are a few ways the ->ssid
> can be changed. Via netlink, from the network or from the an ioctl.
>
> I still have a couple questions, but so far as I can see it's mostly the
> ioctl which has problems.
>
> I really want Smatch to be able to figure the netlink stuff... That
> should be doable.
>
> regards,
> dan carpenter
>