Re: [PATCH] staging: rtl8192e: Fix possible buffer overflow in _rtl92e_wx_set_scan

Lee
2021-03-01T15:38:59Z

> This check worked out pretty well. It's probably 50% bugs? Unfiltered
> results below. The trick of warning for "if (ststr(member, "->ssid")) "
> and the memcpy length couldn't be verified turned out to be the best.

That list looks great. I checked out 2 of those listed at random and
they look like valid bugs to me.

> But there are quite a few real bugs as well. If anyone wants to fix any
> of these just claim a bug, and I won't send a patch for that warning.
> :) Lee, I think you mentioned that you had found a related buffer
> overflow fix? Did the check find it?

I think I found 2 in these files:

drivers/staging/rtl8712/rtl871x_cmd.c
drivers/staging/wfx/hif_tx.c

Regards,
Lee