From: Sasha Levin <sashal@kernel.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Christian Zigotzky <chzigotzky@xenosoft.de>,
Michal Marek <michal.lkml@markovi.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: Fix <linux/version.h> for empty SUBLEVEL or PATCHLEVEL again
Date: Sat, 27 Feb 2021 20:19:36 -0500 [thread overview]
Message-ID: <20210228011936.GD473487@sasha-vm> (raw)
In-Reply-To: <20210227142023.63480-1-masahiroy@kernel.org>
On Sat, Feb 27, 2021 at 11:20:23PM +0900, Masahiro Yamada wrote:
>Commit 9b82f13e7ef3 ("kbuild: clamp SUBLEVEL to 255") breaks the build
>if SUBLEVEL or PATCHLEVEL is empty.
>
>Commit 78d3bb4483ba ("kbuild: Fix <linux/version.h> for empty SUBLEVEL
>or PATCHLEVEL") fixed the issue by prepending a zero.
>
>This time, we cannot take the same approach because we have C code:
>
> #define LINUX_VERSION_PATCHLEVEL $(PATCHLEVEL)
> #define LINUX_VERSION_SUBLEVEL $(SUBLEVEL)
>
>Replace empty SUBLEVEL or PATCHLEVEL with a zero.
>
>Fixes: 9b82f13e7ef3 ("kbuild: clamp SUBLEVEL to 255")
>Reported-by: Christian Zigotzky <chzigotzky@xenosoft.de>
>Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-and-tested-by: Sasha Levin <sashal@kernel.org>
Thank you!
--
Thanks,
Sasha
next prev parent reply other threads:[~2021-02-28 1:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-27 14:20 [PATCH] kbuild: Fix <linux/version.h> for empty SUBLEVEL or PATCHLEVEL again Masahiro Yamada
2021-02-28 1:19 ` Sasha Levin [this message]
2021-03-01 17:10 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210228011936.GD473487@sasha-vm \
--to=sashal@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=chzigotzky@xenosoft.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox