From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Darryl T. Agostinelli" <dagostinelli@gmail.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192u avoid flex array of flex array
Date: Mon, 1 Mar 2021 09:33:12 +0300 [thread overview]
Message-ID: <20210301063312.GK2087@kadam> (raw)
In-Reply-To: <20210228010614.162998-1-dagostinelli@gmail.com>
On Sat, Feb 27, 2021 at 07:06:14PM -0600, Darryl T. Agostinelli wrote:
> Undo the flex array in struct ieee80211_info_element. It is used as the flex
> array type in other structs (creating a flex array of flex arrays) making
> sparse unhappy. This change maintains the intent of the code and satisfies
> sparse.
>
> Signed-off-by: Darryl T. Agostinelli <dagostinelli@gmail.com>
> ---
> drivers/staging/rtl8192u/ieee80211/ieee80211.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h b/drivers/staging/rtl8192u/ieee80211/ieee80211.h
> index 39f4ddd86796..43bb7aeb35e3 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211.h
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211.h
> @@ -951,7 +951,7 @@ struct rtl_80211_hdr_4addrqos {
> struct ieee80211_info_element {
> u8 id;
> u8 len;
> - u8 data[];
> + u8 data[0];
Nah... Just ignore Sparse on this.
regards,
dan carpenter
next prev parent reply other threads:[~2021-03-01 6:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-28 1:06 [PATCH] staging: rtl8192u avoid flex array of flex array Darryl T. Agostinelli
2021-03-01 6:33 ` Dan Carpenter [this message]
2021-03-02 14:18 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210301063312.GK2087@kadam \
--to=dan.carpenter@oracle.com \
--cc=dagostinelli@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox