Re: [PATCH] ARM: dts: imx6sl-tolino-shine2hd: Add Netronix embedded controller

Jonathan Neuschäfer
2021-01-25T20:31:45Z

[-- Attachment #1: Type: text/plain, Size: 1122 bytes --]

On Mon, Jan 25, 2021 at 08:08:04PM +0100, Andreas Kemnade wrote:
> For now, the driver detects an incompatible version, but since
> that can be handled by auto-detection, add the controller to the
> devicetree now. Only PWM seems to be available, there is no RTC
> in that controller.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---

Reviewed-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>

> arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts b/arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts
> index caa279608803..c26bc5e10593 100644
> --- a/arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts
> +++ b/arch/arm/boot/dts/imx6sl-tolino-shine2hd.dts
> @@ -97,8 +97,11 @@ &i2c1 {
> pinctrl-1 = <&pinctrl_i2c1_sleep>;
> status = "okay";
>
> - /* TODO: embedded controller at 0x43 (driver missing) */
> -
> + ec: embedded-controller@43 {
> + compatible = "netronix,ntxec";
> + reg = <0x43>;
> + #pwm-cells = <2>;
> + };

Looks good.

Thanks,
Jonathan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]