From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A27AAC433E0 for ; Mon, 1 Mar 2021 15:06:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7455F64DEF for ; Mon, 1 Mar 2021 15:06:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236796AbhCAPGT (ORCPT ); Mon, 1 Mar 2021 10:06:19 -0500 Received: from elvis.franken.de ([193.175.24.41]:33733 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236883AbhCAPEB (ORCPT ); Mon, 1 Mar 2021 10:04:01 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1lGk4s-00041h-00; Mon, 01 Mar 2021 16:03:18 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 2FAB8C03C2; Mon, 1 Mar 2021 15:49:08 +0100 (CET) Date: Mon, 1 Mar 2021 15:49:08 +0100 From: Thomas Bogendoerfer To: Yury Norov Cc: Will Deacon , Catalin Marinas , Alexander Lobakin , Alexey Klimov , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mips@vger.kernel.org Subject: Re: [PATCH 2/2] MIPS: enable GENERIC_FIND_FIRST_BIT Message-ID: <20210301144908.GC11261@alpha.franken.de> References: <20210225135700.1381396-1-yury.norov@gmail.com> <20210225135700.1381396-3-yury.norov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210225135700.1381396-3-yury.norov@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 25, 2021 at 05:57:00AM -0800, Yury Norov wrote: > From: Alexander Lobakin > > MIPS doesn't have architecture-optimized bitsearching functions, > like find_{first,next}_bit() etc. > It's absolutely harmless to enable GENERIC_FIND_FIRST_BIT as this > functionality is not new at all and well-tested. It provides more > optimized code and saves some .text memory (32 R2): > > add/remove: 4/1 grow/shrink: 1/53 up/down: 216/-372 (-156) > > Users of for_each_set_bit() like hotpath gic_handle_shared_int() > will also benefit from this. > > Suggested-by: Yury Norov > Signed-off-by: Alexander Lobakin > Signed-off-by: Yury Norov > --- > arch/mips/Kconfig | 1 + > 1 file changed, 1 insertion(+) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]