From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C3D9C433E0 for ; Mon, 1 Mar 2021 14:09:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 183C764DF5 for ; Mon, 1 Mar 2021 14:09:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236112AbhCAOJ1 (ORCPT ); Mon, 1 Mar 2021 09:09:27 -0500 Received: from mout01.posteo.de ([185.67.36.65]:58043 "EHLO mout01.posteo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234950AbhCAOHg (ORCPT ); Mon, 1 Mar 2021 09:07:36 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 733EE16005C for ; Mon, 1 Mar 2021 15:06:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1614607599; bh=K44YApsqHwvMN5i7Ti1VW/ra08Wa2N37xaxS1NrZsng=; h=Date:From:To:Cc:Subject:From; b=ZH6bEtXsI9dY7pBozT4GAD9CZqaYSnsQ0R7ZUrWTfQ1ZtolYW0PjOkFoUBDZo7fyo 30NpexvTtJeuizzMtPNoWNGeGmMpima4BQogCfvM2hlqQXQFc5KeMv8NmwjyIKYAjJ OIXf2u0KwSC9ktbodYht5FqrRkeqcKVpJNTNj4wdDaZSCWivs4wVZVSFqt2veNz1oq Pjsdu0Krx/RPayf1OMviBmeQH1ExOdtDg79WwDaaUW36gkYIKnzMzHs8o3si2nosFG ldv9YSY47pM4G9n/yw4nWiZlo7GdF1w64VKP4mXZ+95/hYHL4tG9bM5sTT+03uAwPP zR2h5LsmIWwAw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Dq2B515LJz6tmr; Mon, 1 Mar 2021 15:06:37 +0100 (CET) Date: Mon, 1 Mar 2021 15:06:35 +0100 From: Wilken Gottwalt To: Maxime Ripard Cc: linux-kernel@vger.kernel.org, Ohad Ben-Cohen , Bjorn Andersson , Baolin Wang , Rob Herring , Chen-Yu Tsai , Jernej Skrabec Subject: Re: [PATCH v6 1/2] dt-bindings: hwlock: add sun6i_hwspinlock Message-ID: <20210301150635.480934a8@monster.powergraphx.local> In-Reply-To: <20210301131244.otn7vzhgstufjts2@hendrix> References: <98f75101bbd7d6637aa596a9f43d0ea6372e57c8.1614430467.git.wilken.gottwalt@posteo.net> <20210301131244.otn7vzhgstufjts2@hendrix> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 1 Mar 2021 14:12:44 +0100 Maxime Ripard wrote: > On Sat, Feb 27, 2021 at 02:03:28PM +0100, Wilken Gottwalt wrote: > > Adds documentation on how to use the sun6i_hwspinlock driver for sun6i > > compatible series SoCs. > > > > Signed-off-by: Wilken Gottwalt > > --- > > Changes in v6: > > - fixed formating and name issues in dt documentation > > > > Changes in v5: > > - changed binding to earliest known supported SoC sun6i-a31 > > - dropped unnecessary entries > > > > Changes in v4: > > - changed binding to sun8i-a33-hwpinlock > > - added changes suggested by Maxime Ripard > > > > Changes in v3: > > - changed symbols from sunxi to sun8i > > > > Changes in v2: > > - fixed memory ranges > > --- > > .../hwlock/allwinner,sun6i-hwspinlock.yaml | 45 +++++++++++++++++++ > > The name of the file doesn't match the compatible, once fixed: > Acked-by: Maxime Ripard This is something that still confuses me. What if you have more than one compatible string? This won't be solvable. See the qcom binding for example, there are two strings and none matches. In the omap bindings are also two strings and only one matches. In all cases, including mine, the bindings check script is fine with that. So, you basically want it to be called "allwinner,sun6i-a31-hwspinlock.yaml"? Sorry if I come up with this, but I don't want to just do it, I want to understand it. > Maxime