From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 982D0C4161F for ; Tue, 2 Mar 2021 08:40:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A71C64D9C for ; Tue, 2 Mar 2021 08:40:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381768AbhCBIcg (ORCPT ); Tue, 2 Mar 2021 03:32:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376871AbhCBIQj (ORCPT ); Tue, 2 Mar 2021 03:16:39 -0500 Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [IPv6:2a00:da80:fff0:2::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D548DC061788 for ; Tue, 2 Mar 2021 00:15:42 -0800 (PST) Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 65DF81C0B88; Tue, 2 Mar 2021 09:11:25 +0100 (CET) Date: Tue, 2 Mar 2021 09:11:24 +0100 From: Pavel Machek To: Randy Dunlap Cc: kernel test robot , linux-leds@vger.kernel.org, Amireddy Mallikarjuna reddy , kbuild-all@lists.01.org, clang-built-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: drivers/leds/blink/leds-lgm-sso.c:123:19: error: field has incomplete type 'struct gpio_chip' Message-ID: <20210302081124.GA10699@amd> References: <202102280329.hv7RoHLA-lkp@intel.com> <20210228082913.GA27151@amd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mP3DRpeJDSE+ciuQ" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --mP3DRpeJDSE+ciuQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > >>>> drivers/leds/blink/leds-lgm-sso.c:263:3: error: implicit declaration= of function 'gpiod_set_value' [-Werror,-Wimplicit-function-declaration] > >> gpiod_set_value(led->gpiod, val); > >> ^ > >> drivers/leds/blink/leds-lgm-sso.c:263:3: note: did you mean > >> 'gpio_set_value'? > >=20 > >=20 > > It looks like missing #include? > >=20 > > While at it, can you do something with Kconfig help text? Move > > existing one into comment in the driver, add something useful for end-u= sers. >=20 > The .config file does not set/enable GPIOLIB nor OF. >=20 > AFAICT, this driver needs the addition of: >=20 > #include > #include > #include >=20 > and the reference to > gc->of_node =3D dev->of_node; > needs to be inside an > #ifdef CONFIG_GPIO/#endif block. >=20 > Also, needs a stub for gpiochip_get_data(). >=20 > I have most of that ready (it's in the margin) but I can't > send it tonight. Feel free to fix it up however you want to. Looking forward. I may be confused, but it looks like original author's email bounces, which is a bad sign. What I meant... if you take a look at Kconfig help test, it is really useless. Best regards, Pavel --=20 http://www.livejournal.com/~pavelmachek --mP3DRpeJDSE+ciuQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmA98ywACgkQMOfwapXb+vIiowCfeHP1kO+yiHNCiS1h/Vt4ADQ/ S4kAoMFlF0dR2l3F5Fb9DAVHFEI05cl3 =4l87 -----END PGP SIGNATURE----- --mP3DRpeJDSE+ciuQ--