From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,TVD_SUBJ_WIPE_DEBT,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D0BDC433DB for ; Tue, 2 Mar 2021 19:59:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1108764F1B for ; Tue, 2 Mar 2021 19:59:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1836109AbhCBTnN (ORCPT ); Tue, 2 Mar 2021 14:43:13 -0500 Received: from mail.kernel.org ([198.145.29.99]:50218 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344182AbhCBRPX (ORCPT ); Tue, 2 Mar 2021 12:15:23 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id D05F664F23; Tue, 2 Mar 2021 17:13:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614705237; bh=rTa+VFMAdGMoFocARiaHSEJ8fY06Ra7RcO+lNs2jNXU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mQ/OzDT+b7dShEf/PIDOh13OgJoQyXN0RZ9nYKUZgJ4Lnnbn8dGFKL3BJLkuPmfDl d6PxsAwIPwbbHvNvkOFnzqUu+BAc5tGg8Eqa1Lh1bTRvN0AbneHOanvqs7STcj4jAt 9PzjFFn4LWF6CjEPjNHXrPROUGKh3lZak2afQNaH7aHHDNYtzyTtXLMBN66mvhCyho ge7BsaSZAzbz6HRm0nvMQSvyZgzuAIuqIndmMHQ1lhyjlj08rKQMKFoBTmyG9Uf2HF B+7/tZShZVnQue4BSD8PkTxWe0T+QYIv3gbUv5xcC7IhTyAxXW4bXycpobSJMiRnSe OBqgU+Wets9HA== Date: Tue, 2 Mar 2021 17:12:50 +0000 From: Mark Brown To: Lucas Tanure Cc: James Schulman , David Rhodes , Liam Girdwood , Richard Fitzgerald , alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/15] ASoC: cs42l42: Remove power if the driver is being removed Message-ID: <20210302171250.GO4522@sirena.org.uk> References: <20210302170454.39679-1-tanureal@opensource.cirrus.com> <20210302170454.39679-4-tanureal@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1y1tiN5hVw5cPBDe" Content-Disposition: inline In-Reply-To: <20210302170454.39679-4-tanureal@opensource.cirrus.com> X-Cookie: Friction is a drag. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --1y1tiN5hVw5cPBDe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 02, 2021 at 05:04:42PM +0000, Lucas Tanure wrote: > /* Hold down reset */ > gpiod_set_value_cansleep(cs42l42->reset_gpio, 0); > =20 > + regulator_bulk_disable(ARRAY_SIZE(cs42l42->supplies), cs42l42->supplies= ); Are you sure the device is always runtime resumed on remove? --1y1tiN5hVw5cPBDe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmA+chEACgkQJNaLcl1U h9ATtgf+MNQsl9DYDnA0IuhXNX2UYO8ULD6URRUWSQVUwauxN/xqFUhK/7QkRhbv +uc58aCIkAOTNnd476FGA34BwivjGOt2M6QSpgYywV79rh0zSHaX1g25S8Mbm9I3 arknamPvzPz6hcU9KFCl4zlfhJsUosEuvYmWeUqxrFNUiuYeHjgS56vOVBSatD6z GXEccn3VXpV395tMc2Sp8lUJpZ0RwKdKs1BG5weoSQgDpRiViMweIaLnSUaSUFp5 FB/o91xSAj/NVTkPOGZA9Xcj3rZzQ0VSjE3I/FFvh52QpIQstsTgqn/5TKRunKWD u5g8WGYF/S+1q86m4bpHyShOseqGnw== =Re6y -----END PGP SIGNATURE----- --1y1tiN5hVw5cPBDe--