From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85F54C28D13 for ; Tue, 2 Mar 2021 19:59:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 43F6764F1B for ; Tue, 2 Mar 2021 19:59:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1574613AbhCBTxy (ORCPT ); Tue, 2 Mar 2021 14:53:54 -0500 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:38587 "EHLO wout4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239630AbhCBRX7 (ORCPT ); Tue, 2 Mar 2021 12:23:59 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 21040166B; Tue, 2 Mar 2021 12:22:37 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 02 Mar 2021 12:22:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=n/ryt3OhhTC2QCbydemsESmfflk TtRlovBZzUn8I8HM=; b=S5Cr6s6NTpuWN7JNU+4LZcHsHfI1zMR//yHrxrQCzSW d+3VndYpcWS9T3WEmoJ5e1lSiibEDcHYYCHBlB7xpiSN25N4BphWu34W+m1VeFfv tsmVeR2MhscfWyoD8YnoHO1/FVi/HfG5IHxtqlcbqnbVDQhlTHsfJgYF7TDInWu1 d4rMr0CQXp7n4YkxlrYTI/DfQ98A+aTLQkGzAr/ePOMyHAcxbeav2AT8WoSWd6XK 1FrPLgvuqHexaDqfSjpbG0GdlBsupbwnfzZoNckLr/7BYmVstSYxCOX4gO52/XPM Vs+B0SpDH43q20pjzHmB/t4sb8wI0sbLxvKYeYShRsA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=n/ryt3 OhhTC2QCbydemsESmfflkTtRlovBZzUn8I8HM=; b=hMFw2dC+/R3+ZO484LVvKL 7+a8M1gzUSutQ/8Q3bvYKCu1hKNOOlg7IF7sA61voWgk0zZTR44znHzvc79/RtaF 05llWOHpswnODNN/c0o+/P1K0dFTR3kqiVzsDumTE27f97cTDd/KS5rCpdmqPA4k wPv0eGTa5keEk2lS+JDbCXKsWGGcMKTKbyZHCgRWcC3dLSNbQoKZozv+NxzoWcMh fr1qRnuyJY0tHp2yrQI6wmg/NY9Pjpc/SWsPkk2fJfjQu8z3tOjsbCwW8DMtBWDh rZqxnbdAra/7uXRYqmlcpHaPcEx77/q3J+P31ayKayQ0lP60I7a1spLnIjo2QOnQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddttddgleejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 503A824005C; Tue, 2 Mar 2021 12:22:35 -0500 (EST) Date: Tue, 2 Mar 2021 18:22:33 +0100 From: Maxime Ripard To: Wilken Gottwalt Cc: linux-kernel@vger.kernel.org, Ohad Ben-Cohen , Bjorn Andersson , Baolin Wang , Rob Herring , Chen-Yu Tsai , Jernej Skrabec Subject: Re: [PATCH v6 1/2] dt-bindings: hwlock: add sun6i_hwspinlock Message-ID: <20210302172233.yn6iharipua5ykct@gilmour> References: <98f75101bbd7d6637aa596a9f43d0ea6372e57c8.1614430467.git.wilken.gottwalt@posteo.net> <20210301131244.otn7vzhgstufjts2@hendrix> <20210301150635.480934a8@monster.powergraphx.local> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sw5372ehujb5efr2" Content-Disposition: inline In-Reply-To: <20210301150635.480934a8@monster.powergraphx.local> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --sw5372ehujb5efr2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 01, 2021 at 03:06:35PM +0100, Wilken Gottwalt wrote: > On Mon, 1 Mar 2021 14:12:44 +0100 > Maxime Ripard wrote: >=20 > > On Sat, Feb 27, 2021 at 02:03:28PM +0100, Wilken Gottwalt wrote: > > > Adds documentation on how to use the sun6i_hwspinlock driver for sun6i > > > compatible series SoCs. > > > > > > Signed-off-by: Wilken Gottwalt > > > --- > > > Changes in v6: > > > - fixed formating and name issues in dt documentation > > > > > > Changes in v5: > > > - changed binding to earliest known supported SoC sun6i-a31 > > > - dropped unnecessary entries > > > > > > Changes in v4: > > > - changed binding to sun8i-a33-hwpinlock > > > - added changes suggested by Maxime Ripard > > > > > > Changes in v3: > > > - changed symbols from sunxi to sun8i > > > > > > Changes in v2: > > > - fixed memory ranges > > > --- > > > .../hwlock/allwinner,sun6i-hwspinlock.yaml | 45 +++++++++++++++++= ++ > >=20 > > The name of the file doesn't match the compatible, once fixed: > > Acked-by: Maxime Ripard >=20 > This is something that still confuses me. What if you have more than one > compatible string? In this case, it's fairly easy there's only one :) But we're following the same rule than the compatible: the first SoC that got the compatible wins=20 > This won't be solvable. See the qcom binding for example, > there are two strings and none matches. In the omap bindings are also two > strings and only one matches. In all cases, including mine, the bindings > check script is fine with that. If other platforms want to follow other rules, good for them :) > So, you basically want it to be called > "allwinner,sun6i-a31-hwspinlock.yaml"? Yes Maxime --sw5372ehujb5efr2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYD50WQAKCRDj7w1vZxhR xcdPAP9tzTlvxjihOoXUo/I/ZCFo53W91vxdNey9dArIobAXCQEAlJzbsU/81lkY 0W6mlFveICHKCrvvIvM95phgehldMgU= =gcPq -----END PGP SIGNATURE----- --sw5372ehujb5efr2--