From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFA90C433E0 for ; Thu, 4 Mar 2021 01:38:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A8A6665034 for ; Thu, 4 Mar 2021 01:38:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232066AbhCDBiG (ORCPT ); Wed, 3 Mar 2021 20:38:06 -0500 Received: from mga06.intel.com ([134.134.136.31]:35128 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231966AbhCDBho (ORCPT ); Wed, 3 Mar 2021 20:37:44 -0500 IronPort-SDR: myc3WgeKLqn7vg38XKjxKv8kTcp/uayvBIvf+e3ARRYaHVNuiTVP/51EnyuX6/AfP9gKA0pnGJ dUpMTqt7Dccw== X-IronPort-AV: E=McAfee;i="6000,8403,9912"; a="248717150" X-IronPort-AV: E=Sophos;i="5.81,221,1610438400"; d="scan'208";a="248717150" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2021 17:37:02 -0800 IronPort-SDR: 9RiAkg9sT3iCjF+cUaD22nwn9OPxBvcSrZKvWc6OQTj0pf0K23F21pE+2XMbGJ41Fr44SRkrEq RK04pAPLwMHg== X-IronPort-AV: E=Sophos;i="5.81,221,1610438400"; d="scan'208";a="407491347" Received: from shuo-intel.sh.intel.com (HELO localhost) ([10.239.154.30]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2021 17:36:59 -0800 Date: Thu, 4 Mar 2021 09:36:57 +0800 From: Shuo A Liu To: Borislav Petkov Cc: linux-kernel@vger.kernel.org, x86@kernel.org, Greg Kroah-Hartman , "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , Yu Wang , Reinette Chatre , Zhi Wang , Zhenyu Wang Subject: Re: [PATCH v9 17/18] virt: acrn: Introduce an interface for Service VM to control vCPU Message-ID: <20210304013657.GC9695@shuo-intel.sh.intel.com> References: <20210207031040.49576-1-shuo.a.liu@intel.com> <20210207031040.49576-18-shuo.a.liu@intel.com> <20210303173719.GA30356@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210303173719.GA30356@zn.tnic> User-Agent: Mutt/1.8.3 (2017-05-23) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 3.Mar'21 at 18:37:19 +0100, Borislav Petkov wrote: >On Sun, Feb 07, 2021 at 11:10:39AM +0800, shuo.a.liu@intel.com wrote: >> From: Shuo Liu >> >> ACRN supports partition mode to achieve real-time requirements. In >> partition mode, a CPU core can be dedicated to a vCPU of User VM. The >> local APIC of the dedicated CPU core can be passthrough to the User VM. >> The Service VM controls the assignment of the CPU cores. >> >> Introduce an interface for the Service VM to remove the control of CPU >> core from hypervisor perspective so that the CPU core can be a dedicated >> CPU core of User VM. >> >> Signed-off-by: Shuo Liu >> Reviewed-by: Zhi Wang >> Reviewed-by: Reinette Chatre >> Cc: Zhi Wang >> Cc: Zhenyu Wang >> Cc: Yu Wang >> Cc: Reinette Chatre >> Cc: Greg Kroah-Hartman >> --- >> drivers/virt/acrn/hsm.c | 48 +++++++++++++++++++++++++++++++++++ >> drivers/virt/acrn/hypercall.h | 14 ++++++++++ >> 2 files changed, 62 insertions(+) > >This one causes: > >drivers/virt/acrn/hsm.c: In function ‘remove_cpu_store’: >drivers/virt/acrn/hsm.c:389:3: error: implicit declaration of function ‘remove_cpu’; did you mean ‘register_cpu’? [-Werror=implicit-function-declaration] > remove_cpu(cpu); > ^~~~~~~~~~ > register_cpu >drivers/virt/acrn/hsm.c:402:2: error: implicit declaration of function ‘add_cpu’; did you mean ‘task_cpu’? [-Werror=implicit-function-declaration] > add_cpu(cpu); > ^~~~~~~ > task_cpu >cc1: some warnings being treated as errors >make[3]: *** [scripts/Makefile.build:271: drivers/virt/acrn/hsm.o] Error 1 >make[3]: *** Waiting for unfinished jobs.... >make[2]: *** [scripts/Makefile.build:514: drivers/virt/acrn] Error 2 >make[1]: *** [scripts/Makefile.build:514: drivers/virt] Error 2 >make[1]: *** Waiting for unfinished jobs.... >make: *** [Makefile:1849: drivers] Error 2 This patchset could fix it. https://lore.kernel.org/lkml/20210221134339.57851-1-shuo.a.liu@intel.com/. Thanks shuo