Re: [PATCH] x86/vdso: Use proper modifier for len's printf in extract

Jiri Slaby
2021-03-04T10:57:03Z

On 04. 03. 21, 11:48, Borislav Petkov wrote:
> On Thu, Mar 04, 2021 at 06:18:25AM +0100, Jiri Slaby wrote:
>> It's built with gcc 10 from tumbleweed and it's a standard config from
>> kerncvs:
>> https://github.com/openSUSE/kernel-source/blob/stable/config/i386/pae
>
> Nope, can't trigger with that one either. :-\

Beware:
HOSTCC arch/x86/entry/vdso/vdso2c
^^^^^^
You would need to _be_ on i586. Or try with -m32:

> gcc -m32 -Wp,-MMD,arch/x86/entry/vdso/.vdso2c.d -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 -fomit-frame-pointer -std=gnu89 -I/dev/shm/jslaby/linux/tools/include -I/dev/shm/jslaby/linux/include/uapi -I/dev/shm/jslaby/linux/arch/i386/include/uapi -I ./arch/x86/entry/vdso -o /dev/null /dev/shm/jslaby/linux/arch/x86/entry/vdso/vdso2c.c
> In file included from /dev/shm/jslaby/linux/arch/x86/entry/vdso/vdso2c.c:162:0:
> /dev/shm/jslaby/linux/arch/x86/entry/vdso/vdso2c.h: In function ‘extract64’:
> /dev/shm/jslaby/linux/arch/x86/entry/vdso/vdso2c.h:38:52: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘size_t {aka unsigned int}’ [-Wformat=]
> fprintf(outfile, "static const unsigned char %s[%lu] = {", name, len);
> ~~^
> %u
> In file included from /dev/shm/jslaby/linux/arch/x86/entry/vdso/vdso2c.c:166:0:
> /dev/shm/jslaby/linux/arch/x86/entry/vdso/vdso2c.h: In function ‘extract32’:
> /dev/shm/jslaby/linux/arch/x86/entry/vdso/vdso2c.h:38:52: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘size_t {aka unsigned int}’ [-Wformat=]
> fprintf(outfile, "static const unsigned char %s[%lu] = {", name, len);
> ~~^
> %u

regards,
--
js
suse labs