From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 483C2C15501 for ; Thu, 4 Mar 2021 12:34:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 329FF64F35 for ; Thu, 4 Mar 2021 12:34:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240811AbhCDMdX (ORCPT ); Thu, 4 Mar 2021 07:33:23 -0500 Received: from 8bytes.org ([81.169.241.247]:57642 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240602AbhCDMdO (ORCPT ); Thu, 4 Mar 2021 07:33:14 -0500 Received: by theia.8bytes.org (Postfix, from userid 1000) id 603EB321; Thu, 4 Mar 2021 13:32:33 +0100 (CET) Date: Thu, 4 Mar 2021 13:32:31 +0100 From: Joerg Roedel To: Zenghui Yu Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, dwmw2@infradead.org, baolu.lu@linux.intel.com, will@kernel.org, jacob.jun.pan@linux.intel.com, eric.auger@redhat.com, yi.l.liu@intel.com, kevin.tian@intel.com, wanghaibin.wang@huawei.com Subject: Re: [PATCH] iommu/vt-d: Fix status code for Allocate/Free PASID command Message-ID: <20210304123231.GE26414@8bytes.org> References: <20210227073909.432-1-yuzenghui@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210227073909.432-1-yuzenghui@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 27, 2021 at 03:39:09PM +0800, Zenghui Yu wrote: > As per Intel vt-d spec, Rev 3.0 (section 10.4.45 "Virtual Command Response > Register"), the status code of "No PASID available" error in response to > the Allocate PASID command is 2, not 1. The same for "Invalid PASID" error > in response to the Free PASID command. > > We will otherwise see confusing kernel log under the command failure from > guest side. Fix it. > > Fixes: 24f27d32ab6b ("iommu/vt-d: Enlightened PASID allocation") > Signed-off-by: Zenghui Yu Applied for v5.12, thanks.