From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97926C433DB for ; Sat, 6 Mar 2021 10:31:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5C18F65020 for ; Sat, 6 Mar 2021 10:31:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229957AbhCFKaU (ORCPT ); Sat, 6 Mar 2021 05:30:20 -0500 Received: from elvis.franken.de ([193.175.24.41]:48401 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229738AbhCFKaE (ORCPT ); Sat, 6 Mar 2021 05:30:04 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1lIUCA-0006qw-00; Sat, 06 Mar 2021 11:30:02 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 76D5FC114B; Sat, 6 Mar 2021 10:53:08 +0100 (CET) Date: Sat, 6 Mar 2021 10:53:08 +0100 From: Thomas Bogendoerfer To: Jiaxun Yang Cc: Qing Zhang , Huacai Chen , Thomas Gleixner , Marc Zyngier , "linux-mips@vger.kernel.org" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] MIPS: Loongson64: Move loongson_system_configuration to loongson.h Message-ID: <20210306095308.GA5751@alpha.franken.de> References: <20210304110057.22144-1-zhangqing@loongson.cn> <20210304110057.22144-3-zhangqing@loongson.cn> <20210306080337.GC4744@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 06, 2021 at 05:00:15PM +0800, Jiaxun Yang wrote: > > > On Sat, Mar 6, 2021, at 4:03 PM, Thomas Bogendoerfer wrote: > > On Thu, Mar 04, 2021 at 07:00:57PM +0800, Qing Zhang wrote: > > > The purpose of separating loongson_system_configuration from boot_param.h > > > is to keep the other structure consistent with the firmware. > > > > > > Signed-off-by: Jiaxun Yang > > > Signed-off-by: Qing Zhang > > > --- > > > .../include/asm/mach-loongson64/boot_param.h | 18 ------------------ > > > .../include/asm/mach-loongson64/loongson.h | 18 ++++++++++++++++++ > > > > as you are already touching mach-loongson64 files... > > > > Is there a chance you clean up that up even further ? My goal is to > > have only files in mach- files, which have an mach-generic > > counterpart. Everything else should go to its own directory. So in > > case of loongson something > > > > like > > > > arch/mips/include/asm/loongson for common stuff > > arch/mips/include/asm/loongson/32 > > arch/mips/include/asm/loongson/64 > > Hi Thomas > > I'm object to this idea as loongson32/2ef/64 have nothing in common. at least they share the name loongson, so having arch/mips/include/asm/loongson sounds like a good move. And seeing diff -u mach-loongson2ef/ mach-loongson64/loongson.h | diffstat loongson.h | 137 +++++++++++++------------------------------------------------ 1 file changed, 30 insertions(+), 107 deletions(-) wc mach-loongson2ef/loongson.h 318 963 11278 mach-loongson2ef/loongson.h so there is something to shared. To me it looks like 2ef could be merged into 64, but that's nothing I'm wanting. Just to understand you, you want arch/mips/include/asm/loongson/2ef arch/mips/include/asm/loongson/32 arch/mips/include/asm/loongson/64 ? Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]