[PATCH] x86/smpboot: remove duplicate include in smpboot.c

[PATCH] x86/smpboot: remove duplicate include in smpboot.c

[menglong8.dong]

From: Zhang Yunkai <zhang.yunkai@zte.com.cn>

'cpu_device_id.h' and 'intel_family.h' included in 'smpboot.c'
is duplicated. It is also included in the 80th line.

Signed-off-by: Zhang Yunkai <zhang.yunkai@zte.com.cn>
---
 arch/x86/kernel/smpboot.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index 02813a7f3a7c..ec4bf691fe28 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -1865,9 +1865,6 @@ static bool slv_set_max_freq_ratio(u64 *base_freq, u64 *turbo_freq)
 	return true;
 }
 
-#include <asm/cpu_device_id.h>
-#include <asm/intel-family.h>
-
 #define X86_MATCH(model)					\
 	X86_MATCH_VENDOR_FAM_MODEL_FEATURE(INTEL, 6,		\
 		INTEL_FAM6_##model, X86_FEATURE_APERFMPERF, NULL)
-- 
2.25.1

Re: [PATCH] x86/smpboot: remove duplicate include in smpboot.c

[Borislav Petkov]

On Fri, Mar 05, 2021 at 10:56:10PM -0800, menglong8.dong@gmail.com wrote:
> From: Zhang Yunkai <zhang.yunkai@zte.com.cn>
> 
> 'cpu_device_id.h' and 'intel_family.h' included in 'smpboot.c'
> is duplicated. It is also included in the 80th line.
> 
> Signed-off-by: Zhang Yunkai <zhang.yunkai@zte.com.cn>

If you send another person's patch, then your SOB needs to follow his/hers:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

Also, merge those two x86 patches removing includes into one please.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette