From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B969C433E6 for ; Sat, 6 Mar 2021 11:19:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 68BFB64EDB for ; Sat, 6 Mar 2021 11:19:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230228AbhCFLSm (ORCPT ); Sat, 6 Mar 2021 06:18:42 -0500 Received: from mail.skyhub.de ([5.9.137.197]:57950 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229917AbhCFLSZ (ORCPT ); Sat, 6 Mar 2021 06:18:25 -0500 Received: from zn.tnic (p200300ec2f1bd90027b3ba04162e9c54.dip0.t-ipconnect.de [IPv6:2003:ec:2f1b:d900:27b3:ba04:162e:9c54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 4593E1EC0402; Sat, 6 Mar 2021 12:18:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1615029504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=JoN1l3YjsWEwrhXrFq/YfzpwEnBzmTi0W3gK6nPGqME=; b=h+sN2hlDui3qiKMUUEkZB4261xxER2Z2OdYCbuNAlw9zAB5iqHX5pI4x2Wba/C+XJtNTKQ kF1u/R9tRqxg5d+/302nflbHXiiB464dToOt4yo5aPiF9S883dijFvO9Qm/In1+Wze19TB pwz0onlKPLIcJoakll59FCBLTiH7Kvc= Date: Sat, 6 Mar 2021 12:18:15 +0100 From: Borislav Petkov To: menglong8.dong@gmail.com Cc: tglx@linutronix.de, mingo@redhat.com, x86@kernel.org, hpa@zytor.com, peterz@infradead.org, ggherdovich@suse.cz, rafael.j.wysocki@intel.com, rppt@kernel.org, nathan.fontenot@amd.com, ashok.raj@intel.com, brgerst@gmail.com, linux-kernel@vger.kernel.org, Zhang Yunkai Subject: Re: [PATCH] x86/smpboot: remove duplicate include in smpboot.c Message-ID: <20210306111815.GA7596@zn.tnic> References: <20210306065610.211901-1-zhang.yunkai@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210306065610.211901-1-zhang.yunkai@zte.com.cn> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 05, 2021 at 10:56:10PM -0800, menglong8.dong@gmail.com wrote: > From: Zhang Yunkai > > 'cpu_device_id.h' and 'intel_family.h' included in 'smpboot.c' > is duplicated. It is also included in the 80th line. > > Signed-off-by: Zhang Yunkai If you send another person's patch, then your SOB needs to follow his/hers: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin Also, merge those two x86 patches removing includes into one please. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette